Server Crash with known cause - Server Setters

goncalobsccosta · March 22, 2023, 5:46pm

For a good bug report you should probably include:

Client (production/canary) and FXServer version:

Server - FXServer-master SERVER v1.0.0.5848 win32
Client - Any

What you expected to happen:

The Server not Crashing

What actually happens:

The Server is Crashing

Category of bug (eg. client, server, weapons, peds, native)

The bug is server side, using server setters

Reproducible steps, preferably with example script(s):

Wait until the server has 800 players and then spawn a vehicle or an object using the natives CreateObjectNoOffset, CreateVehicleServerSetter and CreatePed

Here is the full dump file - DUMP

If there are any questions left unanswered feel free to ask!

goncalobsccosta · April 18, 2023, 11:44pm

With further investigation, I can tall that the server crashes when this function starts returning 0

github.com

citizenfx/fivem/blob/ad1fd990dfeeb43727951cb2ac6a7266731448f8/code/components/citizen-server-impl/src/PlayerScriptFunctions.cpp#L225


      
          		}
          		else
          		{
          			static thread_local std::string id;
          			id = std::to_string(host->GetNetId());
          
          
			context.SetResult(id.c_str());
          		}
          	});
          
          
	fx::ScriptEngine::RegisterNativeHandler("GET_PLAYER_PED", MakeClientFunction([](fx::ScriptContext& context, const fx::ClientSharedPtr& client) -> uint32_t
          	{
          		try
          		{
          			return fx::AnyCast<uint32_t>(client->GetData("playerEntity"));
          		}
          		catch (std::bad_any_cast&)
          		{
          			return 0;
          		}
          	}));

I can also tell that the server crashes here:

github.com

citizenfx/fivem/blob/ad1fd990dfeeb43727951cb2ac6a7266731448f8/code/components/citizen-server-impl/src/Client.cpp#L92


      
          
          
	void Client::SetDataRaw(const std::string& key, const std::shared_ptr<AnyBase>& data)
          	{
          		std::unique_lock _(m_userDataMutex);
          		m_userData[key] = data;
          	}
          
          
	std::shared_ptr<AnyBase> Client::GetData(const std::string& key)
          	{
          		std::shared_lock _(m_userDataMutex);
          		auto it = m_userData.find(key);
          
          
		if (it == m_userData.end())
          		{
          			return {};
          		}
          
          
		return it->second;
          	}
          
          
	void Client::SendPacket(int channel, const net::Buffer& buffer, NetPacketType type /* = (ENetPacketFlag)0 */)

And looking at the stack trace I can tell that this is called from here:

github.com

citizenfx/fivem/blob/ad1fd990dfeeb43727951cb2ac6a7266731448f8/code/components/citizen-server-impl/src/GameServer.cpp#L888


      
          			std::vector<fx::ClientSharedPtr> toRemove;
          
          
			uint8_t syncStyle = (uint8_t)m_instance->GetComponent<fx::ServerGameStatePublic>()->GetSyncStyle();
          
          
			m_clientRegistry->ForAllClients([&](fx::ClientSharedPtr client)
          			{
          				auto peer = client->GetPeer();
          
          
				if (peer)
          				{
          					auto lm = client->GetData("lockdownMode");
          					auto lf = client->GetData("lastFrame");
          					auto ss = client->GetData("syncStyle");
          
          
					bool lockdownMode = m_instance->GetComponent<fx::ServerGameStatePublic>()->GetEntityLockdownMode(client) == fx::EntityLockdownMode::Strict;
          
          
					if (!lm || fx::AnyCast<bool>(lm) != lockdownMode ||
          						!ss || fx::AnyCast<uint8_t>(ss) != syncStyle ||
          						!lf ||
          						(m_serverTime - fx::AnyCast<uint64_t>(lf)) > 1000)
          					{

AvarianKnight · April 20, 2023, 5:47am

Might be a good idea to upload your crash dump compressed with something like 7zip

goncalobsccosta · April 20, 2023, 5:00pm

Hi! Sure dump.zip - Google Drive

goncalobsccosta · May 3, 2023, 7:15pm

I’ve updated the artifacts to the most recent version and instead of the server crashing, players are crashing. (Only when using thoose natives)

Here is the CRASH

gottfriedleibniz · May 4, 2023, 12:03am

Looks like you are supplying an incorrect type to CreateVehicleServerSetter. In this instance, “boat” to a model whose VehicleType is not a boat.

mcNuggets1908 · May 14, 2024, 1:04pm

It should still not crash, because of this, but throw an error.

SanGlitcher66 · January 8, 2025, 12:54am

No one has a solution after all this time with the CreateVehicleServerSetter causing the server to crash?