[Release][ESX] [Vangelico Robbery] V 2.0.0 / 2019 SEPTEMBER 02

FiveM Resource Development & Modding Releases
1

[REQUIREMENTS]

[OLD VIDEO]

[NEW VIDEO]

[INSTALLATION]

  1. CD in your resources/[esx] folder
  2. Clone the Git repository https://github.com/ESX-PUBLIC/esx_vangelico_robbery
  3. Import esx_vangelico_robbery.sql in your database
  4. Add this in your server.cfg :
    “start esx_vangelico_robbery”

[ORIGINAL SCRIPT]

[CHANGELOG 2019-09-02]

  • Added green marker (not map blip) on the windows (you can disable or enable into config.lua);
  • Added obligation to have a bag to start the robbery (you can disable or enable into config.lua).

[CHANGELOG 2019-09-01]

  • Clear code;
  • Remove green map blips;
  • Improved the sale of jewelry to Lester;
  • Add 3D text;
  • Add the alarm sound when the robbery start;
  • Add the broken windows sound when collect the jewels;
  • Improved the config file, now it’s too easy change values xD

[ADDITIONAL INFORMATION]:
For additional support please contact me on Discord => Serse Dio Re#3463

19 Likes
2

1000 lines for this? What’s with the repetition i.e copy&paste everywhere?

1 Like
3

I love the thought behind this , and the use of the animation so its not the same repetition.

1 Like
4

some thoughts on this would be to make it so you can be more than one robber and not be able to loot the same case. Also wont the animation look bonkers if you use a gun or any other onehanded weapon?

5

WOOOOOOoooooOOOOOw nice script thank you I love. :heart_eyes: :kissing_heart:

2 Likes
6

What is vangelico?
Could you give me a small explaination

7

Its the Jewelry Store in town

3 Likes
8

it doesn’t send a notification at the police

3 Likes
9

Yeah it send. You can see in my video

10

I don’t see your version on here, why do you complain if some is sharing their version. I like to see when people make their own versions of different mods even if they copy and past maybe he is still learning

Also I don’t see you posting any of your custom mods so try to be nice to the people who do.

8 Likes
11

yes it send iam very sorry
I didn’t take my job

1 Like
12

hmm cool im gonna test this

2 Likes
13

better receive in dirty money ?

xPlayer.addAccountMoney(‘black_money’, bank.reward)

1 Like
14

Good stuff. I checked it out when you posted it to the git earlier.

1 Like
15

Because you don’t do shit doesn’t mean you can’t judge shit

16

I wonder if you were entitled to reflections like that, when you wrote your first script, we humiliated you as you are doing?

2 Likes
17

Really? Well i could say enough about you aswell judging after commenting that. But i will be an adult here and not do it. I can tell if you keep up with attitude like that you will get there in life i’m sure of it ( fyi it was sarcasm )

1 Like
18

Well, you can say what you want, i’m always open for improvements.
I’m a professionnal programmer and all i want is positive judgment on my work to improve myself. I’ve never been hurt by someone better than me, it just raise my motivation to learn and do better

19

Also i was refering to music producers, video game editors and film realisators (and so on) that can be judged by ppl not doing these particular jobs

20

For the easy to make changes, you could follow DRY principle:

1: This following code could be regrouped in one generic method that takes x, y and z as parameters and return your blip. Would save about 100 lines of code

gioielli1 = AddBlipForCoord(-626.5326, -238.3758, 38.05)
SetBlipSprite(gioielli1,1)
SetBlipColour(gioielli1,16742399)
SetBlipScale(gioielli1,0.5)
BeginTextCommandSetBlipName("STRING")
AddTextComponentString(_U('jewelsblipmap'))
EndTextCommandSetBlipName(gioielli1)

2: Same for this, and the improvement is even better

DisplayHelpText(_U('field'))
if IsControlJustReleased(1, 51) then
    local player = GetPlayerPed( -1 )
    if not HasNamedPtfxAssetLoaded("scr_jewelheist") then
        RequestNamedPtfxAsset("scr_jewelheist")
    end
    while not HasNamedPtfxAssetLoaded("scr_jewelheist") do
        Citizen.Wait(0)
    end
    SetPtfxAssetNextCall("scr_jewelheist")
    StartParticleFxLoopedAtCoord("scr_jewel_cab_smash", -626.5326, -238.3758, 38.05, 0.0, 0.0, 0.0, 1.0, false, false, false, false)
    loadAnimDict( "missheist_jewel" ) 
    TaskPlayAnim( player, "missheist_jewel", "smash_case", 8.0, 1.0, -1, 2, 0, 0, 0, 0 ) 
    DisplayHelpText(_U('collectinprogress'))
    DrawSubtitleTimed(5000, 1)
    Citizen.Wait(5000)
    ClearPedTasksImmediately(GetPlayerPed(-1))
    RemoveBlip(gioielli1)
    TriggerServerEvent('esx_vangelico_robbery:gioielli1')
    PlaySound(-1, "PICK_UP", "HUD_FRONTEND_DEFAULT_SOUNDSET", 0, 0, 1)
    hasrobbed = true
end

3: Indent your code properly, it’s unreadable !

4: For further improvement, when point 1 and 2 are done, you could do an object that store x, y, z, blip and your server method name, and iterate on it after the if holdingup then. It would also reduce those RemoveBlip blocs

3 Likes