[RELEASE] [ESX] Lenzh_Chopshop v2!

bitbytes · May 13, 2019, 7:54pm

Thank you - Works great!

Hypnotic_92 · May 14, 2019, 3:30am

Works great minus the cooldown not working!

Mr_Deapz · May 14, 2019, 11:05am

hi, did you modify something or what? I can’t find why i can’t sell

Lenzh_FX · May 14, 2019, 2:04pm

maybe try this

Citizen.CreateThread(function()
	while true do
		Citizen.Wait(0)
		local playerPed = PlayerPedId()
		local coords = GetEntityCoords(playerPed)

		if GetDistanceBetweenCoords(coords, Config.Zones.Shop.coords, true) < 3.0 then
			if not menuOpen then
				ESX.ShowHelpNotification(_U('shop_prompt'))

				if IsControlJustReleased(0, 38) then
					
					OpenShop()
				end
			else
				Citizen.Wait(500)
			end
		end
end)

instead of

Citizen.CreateThread(function()
	while true do
		Citizen.Wait(0)
		local playerPed = PlayerPedId()
		local coords = GetEntityCoords(playerPed)

		if GetDistanceBetweenCoords(coords, Config.Zones.Shop.coords, true) < 3.0 then
			if not menuOpen then
				ESX.ShowHelpNotification(_U('shop_prompt'))

				if IsControlJustReleased(0, 38) then
					wasOpen = true
					OpenShop()
				end
			else
				Citizen.Wait(500)
			end
		else
			if wasOpen then
				wasOpen = false
				ESX.UI.Menu.CloseAll()
			end

			Citizen.Wait(500)
		end
	end
end)

Mr_Deapz · May 14, 2019, 2:47pm

nope, doesn’t work

traks78 · May 14, 2019, 3:59pm

Hi really loving the mod!

do you have any cord sugestions for other scrap yards?

dmcjason23 · May 14, 2019, 5:04pm

why didt you make this a white listed job it would be perfect !

Lenzh_FX · May 14, 2019, 5:05pm

its not a job dude did you even try it?

dmcjason23 · May 14, 2019, 5:18pm

yeah but thats what i mean if it was it would be amazing at the min its just away to farm money but if this was player controlled this would be one of the best releases so far this month

Lenzh_FX · May 14, 2019, 5:20pm

feel free to make it that way…

dmcjason23 · May 14, 2019, 5:25pm

haha im new to lua but i will give it a go when i learn alot more always loved the idea of running a chop shop lol but the way you done your is amazing dude 10/10

KingAlmond · May 14, 2019, 8:37pm

Anyone got client side cool downs +

I would highly suggest a list and cool down on that list, right now on my server, all the petty no roleplay crims are basically farming this.

Lenzh_FX · May 14, 2019, 8:39pm

there is a cooldown

KingAlmond · May 14, 2019, 9:06pm

its global though right?

Relentless_Gam1nG · May 14, 2019, 10:09pm

@Lenzh_FX amaaaazing it works like a charm i cant wait to see what updates you may have later on down the line

Hypnotic_92 · May 14, 2019, 10:51pm

It doesn’t work, even if you try to use it. Not global, not at all. I’m having the same issue as you, where no-rp kids are farming this when PD isn’t on. Had to nerf the pricing until the cooldown gets fixed.

BorgoMadonno · May 15, 2019, 12:00am

Hello @Lenzh_FX, wonderful release.

I just have a problem: when I open the sell menu I get an error about a nil value (field ‘Math’), something messing with ESX.Math.GroupDigits so I tried to change this in client\main.lua, line 75:

label = ('%s - <span style="color:green;">%s</span>'):format(v.label, _U('item', ESX.Math.GroupDigits(price))),

with this one

label = ('%s - <span style="color:green;">%s</span>'):format(v.label, _U('item', (price))),

The menu is now opening, dunno what’s going on with ESX.Math. The problem is that when I press Enter to sell parts (items I own in the inventory ofc) I don’t sell anything, I don’t get any notification about selling and I still have items in inventory.
Can you help me please?

Thanks.

Mr_Deapz · May 15, 2019, 12:32am

With this change i finally got the menu open, but like you, when i click to spend nothing happens;
i cannot open the menu twice, until i DC

iPaGHD · May 15, 2019, 4:07pm

I have the same problem for a long time now, and yes I have updated ex extended and essential mode, it seems to be incompatibility with other resources that we have on our servers. He can’t fix what he can’t replicate on his server. So, better not to use it at all…

BorgoMadonno · May 15, 2019, 9:24pm

Guys I fixed it:

Go here https://github.com/ESX-Org/es_extended and download the zip;
Copy the “common” folder you find in the zip into the server’s “es_extended” folder;
Go into es_extended and open the “__resource.lua” file;
Add this code both in server_scripts and client_scripts;

'common/modules/math.lua'

Save and restart the server.

Add the code like I did here:

Screenshot

It worked for me, hope it will for you too.