how do i make the server public so people can join it just shows offline and private
If it is not showing on the Server List then it is probably not public. If it is showing in the server list but other players cannot see it in FiveM they can try join using the direct connect link that shows when you click on the server in the Server List, then use it in the F8 console i.e. connect cfx.re/join/XxXxXxX. If you are hosting your server locally you will need to enable port forwarding on your router so it can be seen outside of your network.