Whitelist script based off of an API

xander1998 · 2018-08-23T19:36:57.607Z

I just posted code for you to try. You are still using the code you had before…

AttributeError · 2018-08-23T19:41:48.981Z

Oops, didn’t notice you changed the callback, my apologies. I’ve made it so it prints the result returned from the server and it posts the same as if I were to visit the page myself. I then changed it so that it printed the decoded JSON, and it printed the same (just obviously more human-readable).

So, there’s information being returned from the server, just it can’t seem to find the ‘results’ part of the data…

xander1998 · 2018-08-23T19:43:03.781Z

Well for me to better understand how results is being returned the only way is for me to see what is being returned. I can’t guess how results is being returned as an API can return the JSON data in any way you want it. If it has personal data I can’t help you on the forums for obvious reasons.

AttributeError · 2018-08-23T19:45:49.681Z

I can provide you with a snippet, I’ve removed all the personal information. Hopefully this helps…

{
    "page": 1,
    "perPage": 25,
    "totalResults": 17,
    "totalPages": 1,
    "results": [
        {
            "id": 1,
            "name": "[redacted]",
            "title": null,
            "timeZone": "[redacted]",
            "formattedName": "[redacted]",
            "primaryGroup": {
                "id": 4,
                "name": "Director",
                "formattedName": "<span style='color:#0091ff'>Director<\/span>"
            },
            "secondaryGroups": [],
            "email": "[redacted]",
            "joined": "2018-08-23T02:00:22Z",
            "registrationIpAddress": "",
            "warningPoints": 0,
            "reputationPoints": 0,
            "photoUrl": "\/\/content.invisioncic.com\/i283215\/monthly_2018_08\/Twitter2.png.25fedc72aa3eeec2d474c48cdb9af09b.png",
            "photoUrlIsDefault": false,
            "coverPhotoUrl": "\/\/content.invisioncic.com\/i283215\/monthly_2018_08\/header.png.f4fedd2f26ed931a92be728f8ac7c30d.png",
            "profileUrl": "[redacted]",
            "validating": false,
            "posts": 3,
            "lastActivity": "2018-08-23T15:12:58Z",
            "lastVisit": "2018-08-23T14:44:44Z",
            "lastPost": "2018-08-23T07:44:06Z",
            "profileViews": 65,
            "birthday": "6\/11",
            "customFields": {
                "1": {
                    "name": "Personal Information",
                    "fields": {
                        "1": {
                            "name": "About Me",
                            "value": ""
                        },
                        "2": {
                            "name": "Steam HEX",
                            "value": "steam:1100001159e53eb"
                        }
                    }
                }
            }
        },

xander1998 · 2018-08-23T19:48:15.057Z

Ok so when you ran my code snippet did it print that or was it still nil?

AttributeError · 2018-08-23T19:48:33.654Z

It printed perfectly fine, same if I just printed the JSON without trying to index it or anything.

xander1998 · 2018-08-23T19:50:55.348Z

AddEventHandler("playerConnecting", function(name, kickReason, deferrals)
	deferrals.defer()
	PerformHttpRequest("[url]", function(code, data, headers)
		if code == 200 then
			local data = json.decode(data)
			local results = data["results"][1]
			print(json.encode(results))
			deferrals.done()
		else
			deferrals.done("Whitelist Connection Issue. Please try again later .. [" .. code .. "]")
		end
	end, "GET", json.encode({}), {["Content-Type"] = "application/json", ["User-Agent"] = "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.106 Safari/537.36"})
end)

See if that print message only returns the results portion.

AttributeError · 2018-08-23T19:52:17.095Z

Nope, threw an error saying that results wasn’t defined…
Full stacktrace:

Error Code: 200
Error running system event handling function for resource salrp-utils: citizen:/scripting/lua/scheduler.lua:41: Failed to execute thread: whitelist_server.lua:9: attempt to index a nil value (field 'results')
stack traceback:
        whitelist_server.lua:9: in local 'userCallback'
        citizen:/scripting/lua/scheduler.lua:274: in upvalue 'handler'
        citizen:/scripting/lua/scheduler.lua:175: in function <citizen:/scripting/lua/scheduler.lua:174>
stack traceback:
        [C]: in function 'error'
        citizen:/scripting/lua/scheduler.lua:41: in field 'CreateThreadNow'
        citizen:/scripting/lua/scheduler.lua:174: in function <citizen:/scripting/lua/scheduler.lua:138>

Code:

AddEventHandler('playerConnecting', function(playerName, setKickReason, deferrals)
	deferrals.defer()
	Citizen.Wait(0)
	
	local func = PerformHttpRequest("[url]", function(errorCode, resultData, resultHeaders)
		print("Error Code: " .. tostring(errorCode))
		if(tostring(errorCode) == "200") then			
			local data = json.encode(data)
			local results = data["results"][1]
			print(json.encode(results))
			
			deferrals.done("yote")
		else 
			deferrals.done("There was an error whilst contacting the server! Please try again later. " .. tostring(errorCode))
		end
	end, "GET", json.encode( {} ), { ["Content-Type"] = "application/json", ["User-Agent"] = "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.106 Safari/537.36" })
end);

xander1998 · 2018-08-23T19:54:22.570Z

AddEventHandler("playerConnecting", function(name, kickReason, deferrals)
	deferrals.defer()
	PerformHttpRequest("[url]", function(code, data, headers)
		if code == 200 then
			local data = json.decode(data[1])
			local results = data["results"][1]
			print(json.encode(results))
			deferrals.done()
		else
			deferrals.done("Whitelist Connection Issue. Please try again later .. [" .. code .. "]")
		end
	end, "GET", json.encode({}), {["Content-Type"] = "application/json", ["User-Agent"] = "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.106 Safari/537.36"})
end)

Maybe data needs to be indexed?

You should really be copy pasting my code… I am changing things you are not changing.

AttributeError · 2018-08-23T19:59:04.425Z

Okay, I copy/pasted your code and just replaced the URL (obviously) and it returned this:

Error running system event handling function for resource salrp-utils: citizen:/scripting/lua/scheduler.lua:41: Failed to execute thread: citizen:/scripting/lua/json.lua:397: bad argument #1 to 'strfind' (string expected, got nil)
stack traceback:
        [C]: in function 'string.find'
        citizen:/scripting/lua/json.lua:397: in upvalue 'scanwhite'
        citizen:/scripting/lua/json.lua:553: in function <citizen:/scripting/lua/json.lua:551>
        (...tail calls...)
        whitelist_server.lua:5: in local 'userCallback'
        citizen:/scripting/lua/scheduler.lua:274: in upvalue 'handler'
        citizen:/scripting/lua/scheduler.lua:175: in function <citizen:/scripting/lua/scheduler.lua:174>
stack traceback:
        [C]: in function 'error'
        citizen:/scripting/lua/scheduler.lua:41: in field 'CreateThreadNow'
        citizen:/scripting/lua/scheduler.lua:174: in function <citizen:/scripting/lua/scheduler.lua:138>

Presumably doesn’t like the data[1] part…

xander1998 · 2018-08-23T20:04:55.078Z

ok just remove the [1] part from data and try it. I noticed when you sent me the error earlier you were missing pieces I sent you.

AttributeError · 2018-08-23T20:06:21.470Z

Same code as before, just without indexing the data before decoding it…

AddEventHandler("playerConnecting", function(name, kickReason, deferrals)
	deferrals.defer()
	PerformHttpRequest("[url]", function(code, data, headers)
		if code == 200 then
			local data = json.decode(data)
			local results = data["results"][1]
			print(json.encode(results))
			
			deferrals.done("stop connecting for testing..")
		else
			deferrals.done("Whitelist Connection Issue. Please try again later .. [" .. code .. "]")
		end
	end, "GET", json.encode({}), {["Content-Type"] = "application/json", ["User-Agent"] = "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.106 Safari/537.36"})
end)

Same error as before:

Error running system event handling function for resource salrp-utils: citizen:/scripting/lua/scheduler.lua:41: Failed to execute thread: whitelist_server.lua:6: attempt to index a nil value (field 'results')
stack traceback:
        whitelist_server.lua:6: in local 'userCallback'
        citizen:/scripting/lua/scheduler.lua:274: in upvalue 'handler'
        citizen:/scripting/lua/scheduler.lua:175: in function <citizen:/scripting/lua/scheduler.lua:174>
stack traceback:
        [C]: in function 'error'
        citizen:/scripting/lua/scheduler.lua:41: in field 'CreateThreadNow'
        citizen:/scripting/lua/scheduler.lua:174: in function <citizen:/scripting/lua/scheduler.lua:138>

xander1998 · 2018-08-23T20:10:53.331Z

You might wanna remove the URL?

I am just taking a look at the code for a second.

xander1998 · 2018-08-23T20:15:43.506Z

Contact me on discord so that doesn’t happen again.

AttributeError · 2018-08-23T20:52:49.045Z

Alright… after talking in Discord for a bit, we came to the conclusion it was PHP. I made the REST API use NodeJS and did the requests that way, updated my resource to use the new URL and it returned a table for the first print statement.

Harrison_Mayotte · 2020-07-13T21:19:17.295Z

Do you still have access to this resource? If so, is there a way you would be willing to share the resource (publicly or privately)?

AttributeError · 2020-07-14T07:19:42.075Z

I don’t have the resource itself, but the code above should work fine - although it was from two years ago so it may need some tweaking?

Harrison_Mayotte · 2020-07-14T12:56:38.205Z

Alright.

AttributeError:

to the conclusion it was PHP. I made the REST API use NodeJS

Where was this issue/should I expect to encounter this?

AttributeError · 2020-07-14T13:09:18.674Z

From what I can remember, the issue was with PHP not returning the data I wanted properly. Since I don’t have any of the code for the API anymore, I really don’t know what was actually wrong.

Harrison_Mayotte · 2020-07-14T13:21:49.933Z

Alright. I appreciate you replying!