Vehicle Decorators Failing to Save

bgmc · 2019-08-21T21:46:27.508Z

Perhaps I’m just overlooking something very obvious (I probably am), but I seem to be having some real troubles with decorators saving on vehicles. I had a fairly complex function prior that was failing to work, so I brought it down to it’s simplest form to test if decorators were working.

AddEventHandler("testEvent", function(veh)
    Citizen.CreateThread(
        function()
            DecorSetBool(veh, "test", true)
            print(tostring(DecorGetBool(veh, "test")))
            DecorSetBool(veh, "test", false)
            print(tostring(DecorGetBool(veh, "test")))
        end
    )
end)

When I run the above (The code itself runs fine as far as I can tell and veh is the vehicle entity that I want), the following is printed:

false
false

Instead of what I would expect:

true
false

I looked for a possible native to push the decorators (so-to-speak) but didn’t find anything. Am I missing something or should I be doing something different? Any help is appreciated!

xander1998 · 2019-08-21T21:53:46.259Z

Are you passing a valid vehicle to the veh argument?

bgmc · 2019-08-21T21:58:57.854Z

As far as I can tell, yes… Prior to posting here, I included some other debug information such as plate, vehicle color, etc. in my prints and it all matched the vehicle I had expected. So it’s definitely seems to be passing a valid vehicle.

xander1998 · 2019-08-21T22:04:24.384Z

Did you register the decorator before calling it?

bgmc · 2019-08-21T22:08:18.505Z

Ah, that’s probably it. I knew it would be something simple. I assume that would be

DecorRegister("test", 2)

There’s not much documentation for decorators unfortunately and the DecorRegister native in the docs doesn’t seem to have a number assigned to boolean, so just going off the order, I assume it’s 2?

xander1998 · 2019-08-21T22:10:17.259Z

Yes it would be 2

I would also like to point out

Citizen.CreateThread(function()
	DecorRegister("test", 2)
end)

AddEventHandler("eventName", function(veh)
	DecorSetBool(veh, "test", true)
	print(tostring(DecorGetBool(veh, "test")))
	DecorSetBool(veh, "test", false)
	print(tostring(DecorGetBool(veh, "test")))
end)

You don’t need to manually thread an event handler. FiveM by default already threads them for you. So no need for Citizen.CreateThread inside that event for that type of code. I know you are doing this for just testing purposes but you shouldn’t really need to add another thread in there so was just making sure you knew it was already threaded.

bgmc · 2019-08-21T22:18:53.653Z

Ah, good to know… I wasn’t aware that it automatically created the thread. Thanks for the help!

xander1998 · 2019-08-21T22:25:36.523Z

Ur welcome glad it was an easy fix.