[V8][NODE.JS] console.* functions don't get executed as defined in console.js

IceHax · 2018-09-02T19:49:49.191Z

Description

any console.* function doesnt get executed in the way defined in the console.js file.

As an example, console.err should append "Error: " to the message being passed as argument, but it doesnt.
similarily, all the console.* commands dont follow the instructions given in console.js. This can also be noticed by the fact that the text is being printed on the console, but it is not being logged to the CitizenFX.log file. a similar thing happens also for the runtime exceptions, they get printed but not logged.

Repro

here’s a simple repro:

console.log("this won't get saved, only printed")
console.warn("this will just get printed")
console.error("this will just get printed")
print("this will get printed and saved")
Citizen.trace("this will get printed and saved")

and upon running it this is the result:

Server console:

CitizenFX.log:

[       391] this will get printed and saved
[       391] this will get printed and saved

i have tried everything in my power to find out what code this ends up executing instead of going through V8_Trace, but i’m yet to find an answer, after a couple hours of troubleshooting i ended up writing this bug report, so that other people could take a look at the situation as well.

zr0iq · 2018-09-02T19:59:01.751Z

Experienced this issue as well.

lawrencium · 2018-09-02T21:05:18.987Z

Does this affect the client as well, or only the server?

lutetium · 2018-09-02T21:11:30.737Z

OK, after reading the horribly-written bug report 5 times or so, it’s slightly more evident that this is the server, and a quick console.log(console) showed that the console class from Node.js vendor/node/lib/console.js is being used, because it has members not defined in data/shared/citizen/scripting/v8/console.js.

It seems we should define the following flag to prevent vendor/node/lib/internal/bootstrap_node.js from overwriting timers and console with its own functions - but this can and will break compatibility with certain Node.js modules in case the CitizenFX-specific console class (or timer functions?) doesn’t have required fields:

#ifdef NODE_NO_BROWSER_GLOBALS
  // configure --no-browser-globals
  READONLY_PROPERTY(process, "_noBrowserGlobals", True(env->isolate()));
#endif  // NODE_NO_BROWSER_GLOBALS

Since nobody(?) is using the Node.js API in production, anyway, let’s try defining that.

thorium.90 · 2018-09-02T21:51:42.347Z

github.com/citizenfx/fivem

server/v8: define NODE_NO_BROWSER_GLOBALS so that Node.js does not try defining its own console

committed 09:12PM - 02 Sep 18 UTC

blattersturm

+1 -1

There.

For the idiot bug report, you also got a free punishment:

github.com/citizenfx/fivem

utils: fix oversight causing a non-rotating CitizenFX.log to be written by Win32 FXS builds

committed 09:46PM - 02 Sep 18 UTC

blattersturm

+2 -0

this _may_ be replaced with a proper CoreConsole listener in the future, implemented in the actual server component

IceHax · 2018-09-02T21:54:09.692Z

thanks a lot, and sorry for the idiot bug report