TerminateThisThread not working at all

Shiroyo · 2019-09-12T19:31:14.813Z

Hello. I have a problem with terminating thread.

function PlayMusicInLoop(audio, length)
    KeepPlaying = true
    Citizen.CreateThread(function()
        while KeepPlaying do
            TriggerEvent('LIFE_CL:Sound:PlayOnOne', audio, 0.05)
            Citizen.Wait(length)
        end
        TerminateThisThread()
    end)
end

function Example()
        PlayMusicInLoop('resident2', 189000)
        Citizen.Wait(5000)
        KeepPlaying = false -- even with that the previous PlayMusicInLoop still works
        -- I tried adding Citizen.Wait(1000) here, but that does nothing
        PlayMusicInLoop('resident3', 125000)
end

So it should work like this: Music starts and works in this case for 5 seconds. After that KeepPlaying is set to false so the thread should be destroyed/terminated. The problem is when I start another PlayMusicInLoop, it seems that previous thread isn’t destroyed bcause I still got to hear 2 music files in different time order, just as set in length.

TheIndra · 2019-09-12T19:37:33.432Z

TerminateThisThread() is a game threading native, it doesn’t work with citizen threads, the thread should however end while the code is done executing

Also the question is kinda vague, but you are opening a new thread in PlayMusicInLoop() function meaning the code in Example() just continues and plays 5 seconds later, i’m not sure how LIFE_CL:Sound:PlayOnOne function works but you don’t seem to be canceling that sound play

Shiroyo · 2019-09-12T19:45:31.888Z

LIFE_CL:Sound:PlayOnOne starts playing certain sounds file for one client. When another LIFE_CL:Sound:PlayOnOne starts, the previous one is cancelled, so you can’t hear 2 sound files at the same time. This Example function is just for this topic, it’s not in my script. I want to start one looped music file at the beginning of the mission so it loops infinitely and when the mission ends (for example after 10 minutes) the previous looped music is terminated and the new one should start cancelling the previous one. Even though the loop should end when setting KeepPlaying to false it seems that the loop is still alive.

TheIndra · 2019-09-12T19:48:25.141Z

Also I see another problem with your code

Shiroyo:

while KeepPlaying do
    TriggerEvent('LIFE_CL:Sound:PlayOnOne', audio, 0.05) 
    Citizen.Wait(length) 
end

It will wait 189000ms before checking again if KeepPlaying is false, so if you wait 5000ms in another thread it will ofcourse still run that thread because that’s still waiting

Shiroyo · 2019-09-12T19:52:20.102Z

Ohhh, you are right. Silly me. As usually the problem is closer than you think