[Solved] Peds stacking up

PEPSI_WK · 2019-07-06T07:51:12.583Z

Any idea to fix peds stack up per player?

By default it should be 3 peds but when we got more player its stack up like 1 = 3 , 2 = 6 , 3 = 9 something like this.
What I did wrong?

local Props = {}
local isPickingUp, isProcessing = false, false
local Propsno = 0

Citizen.CreateThread(function()
	while true do
		Citizen.Wait(10)
		local coords = GetEntityCoords(PlayerPedId())

		if GetDistanceBetweenCoords(coords, Config.zones.milk.coords, true) < 50 then
			SpawnProps()
			Citizen.Wait(500)
		else
			Citizen.Wait(500)
		end
	end
end)

Citizen.CreateThread(function()
	while true do
		Citizen.Wait(0)
		local playerPed = PlayerPedId()
		local coords = GetEntityCoords(playerPed)

		if GetDistanceBetweenCoords(coords, Config.zones.process.coords, true) < 1 then
			if not isProcessing then
				ESX.ShowHelpNotification(_U('Procress'))
			end

			if IsControlJustReleased(0, 38) and not isProcessing then
					Process()
			end
		else
			Citizen.Wait(500)
		end
		
	end
end)

Citizen.CreateThread(function()
	while true do
		Citizen.Wait(0)

		for index, value in pairs(Config.AnimalPositions) do
			DrawMarker(20, value.x, value.y, value.z+1.5, 0, 0, 0, 0, 0, 0, 0.5, 0.5, 0.5, 240,230,140, 165, 1,0, 0,1)	
		end
		
	end
end)

function Process()
	isProcessing = true

	TriggerEvent('mythic_notify:client:SendAlert', { type = 'success', text = _U('Processcoming') })
	TriggerServerEvent('crossbite_milk:process')
	local timeLeft = Config.WaitProcess
	local playerPed = PlayerPedId()
	local ped = GetPlayerPed(-1)
	exports['progressBars']:startUI(10000, "กำลัง Process นมวัวกล่อง..")
		--Citizen.Wait(5000)
		ClearPedTasks(playerPed)
		--Citizen.Wait(1500)
		
	while timeLeft > 0 do
		FreezeEntityPosition(ped, true)
		Citizen.Wait(1000)
		timeLeft = timeLeft - 1
		if GetDistanceBetweenCoords(GetEntityCoords(playerPed), Config.zones.process.coords, false) > 4 then
			TriggerServerEvent('crossbite_milk:cancelProcessing')
			break
		end
	end
	FreezeEntityPosition(ped, false)
	isProcessing = false
end

Citizen.CreateThread(function()
	while true do
		Citizen.Wait(0)
		local playerPed = PlayerPedId()
		local coords = GetEntityCoords(playerPed)
		local nearbyObject, nearbyID

		for i=1, #Props, 1 do
			if GetDistanceBetweenCoords(coords, GetEntityCoords(Props[i]), false) < 2 then
				nearbyObject, nearbyID = Props[i], i
			end
		end

			
		if nearbyObject and IsPedOnFoot(playerPed) then
				DisableControlAction(0, 24, true) -- Attack
				DisableControlAction(0, 257, true) -- Attack 2
				DisableControlAction(0, 25, true) -- Aim
				DisableControlAction(0, 263, true) -- Melee Attack 1
				DisablePlayerFiring(GetPlayerPed(-1), true) -- Disable weapon firing
			
		
			
				if not isPickingUp then
					ESX.ShowHelpNotification(_U('Milk'))
				end

					if IsControlJustReleased(0, 38) and not isPickingUp then
						ESX.TriggerServerCallback('crossbite_milk:haveItem', function(haveItem)
							if haveItem then
								isPickingUp = true

								ESX.TriggerServerCallback('crossbite_milk:canPickUp', function(canPickUp)
										
										if canPickUp then
											--TaskStartScenarioInPlace(playerPed, 'WORLD_HUMAN_GARDENER_PLANT', 0, false)
											while not HasAnimDictLoaded(Config.animalDirectory1) and not HasAnimDictLoaded(Config.animalDirectory2) do
												Citizen.Wait(0)
											end
											--TaskPlayAnim(PlayerPedId(), Config.animalDirectory1 ,"base" ,8.0, -8.0, -1, 1, 0, false, false, false )
											Citizen.Wait(100)
											
											TaskPlayAnim(PlayerPedId(), Config.animalDirectory2 ,"player_search" ,8.0, -8.0, -1, 48, 0, false, false, false )
											exports['mythic_progbar']:Progress({
											name = 'milk_action',
											duration = Config.WaitTimePickup,
											label = _U('Processcoming'),
											useWhileDead = false,
											canCancel = true,
											controlDisables = {
												disableMovement = true,
												disableCarMovement = true,
												disableMouse = false,
												disableCombat = true,
											},
											animation = {
												animDict = Config.animalDirectory1,
												anim = 'base',
												--flags = 49,
											},
											prop = {
												model = 'prop_bucket_01b',
												bone = 60309,
												coords = { x = 0.0, y = 0.1, z = 0.5 },
												rotation = { x = 364.0, y = 180.0, z = 90.0 },
											}
											},  function(status)
													TriggerServerEvent('crossbite_milk:pickedUp')
											end)
											
											Citizen.Wait(8000)
											ClearPedTasks(playerPed)
											Citizen.Wait(1)
											ClearPedTasksImmediately(PlayerPedId())
											FreezeEntityPosition(PlayerPedId(), false)
							
											
										end

										isPickingUp = false
									
								end, 'milk')
							
							else
									ESX.ShowNotification(_U('Needbuy'))
							end
							
						end, 'milk_engine')
					end
		else
			Citizen.Wait(500)
		end

	end

end)
AddEventHandler('onResourceStop', function(resource)
	if resource == GetCurrentResourceName() then
		for k, v in pairs(Props) do
			DeleteEntity(v)
		end
	end
end)

function SpawnProps()
	while Propsno < Config.Props do
		Citizen.Wait(0)
		for index, value in pairs(Config.AnimalPositions) do
			local Animal = CreatePed(5, GetHashKey(Config.animalname), value.x, value.y, value.z, 0.0, true, false)
			--DrawMarker(20, value.x, value.y, value.z+1.5, 0, 0, 0, 0, 0, 0, 0.5, 0.5, 0.5, 240,230,140, 165, 1,0, 0,1)	
			--DrawMarker(20, value.x, value.y, value.z+1.5, 0.0, 0.0, 0.0, 0, 0.0, 0.0, 0.5, 0.5, 0.5, 0, 255, 0, 100, false, true, 2, false, false, false, false)
		  	
			
			--TaskWanderStandard(Animal, true, true)
			--SetEntityAsMissionEntity(Animal, true, true)
			table.insert(Props, Animal)
			Propsno = Propsno + 1
			Citizen.Wait(500)
			FreezeEntityPosition(Animal, true)
			SetEntityInvincible(Animal,true)
			SetEntityOnlyDamagedByPlayer(Animal, false)
			SetEntityCanBeDamaged(Animal, false)
			SetPedCanRagdoll(Animal, false)
			ClearPedBloodDamage(Animal)
			ResetPedVisibleDamage(Animal)
		end
		
	end

end

local Animal = CreatePed(5, GetHashKey(Config.animalname), value.x, value.y, value.z, 0.0, true, false)

change 7th parameter to false Ped Spawning per player

local Animal = CreatePed(5, GetHashKey(Config.animalname), value.x, value.y, value.z, 0.0, false, false)

SpikE_Odets · 2019-07-06T10:54:56.851Z

The script is running on all the clients… so all 3 are spawing the peds they are suppost to. To keep this from happening you would need to have it check to see if the peds are already spawned and if not then spawn them.

SpikE

PEPSI_WK · 2019-07-06T11:02:50.310Z

Thanks for your answer.
I understand all of your words.
But I actually dont know how to write something to check if peds is in the server yet?
Can you please give me an example.

So sorry about this I’m pretty new on LUA language

SpikE_Odets · 2019-07-06T11:24:16.021Z

Since it looks like you are freezing the animals where they are you can use the same coords you use to spawn the animals to check for them…

local animalcheck = GetClosestPed(x, y, z, radius (since you spawned it can make radius small), boolean, boolean , boolean , boolean , 28 (this is the ped type-28 is for animal)

if animcalcheck == 0 then
spawnanimal for these coords
end

I do not have my test server up atm… but something like this should give you an idea of how you need to search for them before you spawn one in. Read up on the native for GetClosestPed to find out what the boolen;s are used for and play around with the setting until you get it sorted out.

Hope this helps a bit

SpikE

PEPSI_WK · 2019-07-06T11:24:56.611Z

Ty for your help sir, I solved by this thread Ped Spawning per player

SpikE_Odets · 2019-07-06T11:25:29.798Z

Glad you found a solution then and looking over that… is alot simpler then my idea was. I didn’t know about that option at all. So learned something myself.

Domy_97 · 2020-11-06T15:01:15.868Z

it’s milk job?
where can i find the complete code of this work?