[SOLVED] GetPedSourceOfDeath Issues

ValonGP · 2019-04-28T00:14:38.321Z

Hello there,

Facing an issue where I’m simply trying to scan the surounding area for pedestrians, checking if they’re dead, then checking for their source of death.

Now I have the following which I found while scanning the forums for establishing and looping through a list of pedestrians within a given radius.

function GetNearbyPeds(x, y, z, radius)
	local nearby = {}
	for ped in EnumeratePeds() do
		if DoesEntityExist(ped) then
			px,py,pz = table.unpack(GetEntityCoords(ped, true))
			if GetDistanceBetweenCoords(px,py,pz,x,y,z,true) <= radius then
				table.insert(nearby,ped)
			end
		end
	end
	return nearby
end

local entityEnumerator = {
    __gc = function(enum)
        if enum.destructor and enum.handle then
            enum.destructor(enum.handle)
        end
        enum.destructor = nil
        enum.handle = nil
    end
}

local function EnumerateEntities(initFunc, moveFunc, disposeFunc)
    return coroutine.wrap(function()
        local iter, id = initFunc()
        if not id or id == 0 then
            disposeFunc(iter)
            return
        end
      
        local enum = {handle = iter, destructor = disposeFunc}
        setmetatable(enum, entityEnumerator)
      
        local next = true
        repeat
            coroutine.yield(id)
            next, id = moveFunc(iter)
        until not next
      
        enum.destructor, enum.handle = nil, nil
        disposeFunc(iter)
    end)
end

Now the issue I’m facing is that while looping through the nearby pedestrians, upon checking their source of death I’m being hit with “attempt to call a nil value (global ‘GetPedSourceOfDeath’)”.

This is the basic thread i have to test this.

Citizen.CreateThread(function()
	while true do
		Citizen.Wait(500)
		local x,y,z = table.unpack(GetEntityCoords(GetPlayerPed(-1), true))
		for _,ped in pairs(GetNearbyPeds(x,y,z,100.0)) do
			if DoesEntityExist(ped) and IsPedDeadOrDying(ped, 1) and GetPedMaxHealth(ped) == 100 then
				if GetPedSourceOfDeath(ped) == GetPlayerPed(-1) then
					SetPedMaxHealth(ped, 80)
					TriggerEvent('nls:set-credits', credits + 1)
				end
			end
		end
	end
end)

I assumed at first that the result of the check was simply nil, however it appears the actual function “GetPedSourceOfDeath” itself is nil, which just raises further questions.

blcd · 2019-04-28T04:33:04.628Z

Works fine here after changing GetPedMaxHealth(ped) == 100 to GetPedMaxHealth(ped) ~= 80 since not all Peds have 100 health. Are you running this as a client or server script? Even with OneSync, GetPedSourceOfDeath doesn’t exist on the server.

ValonGP · 2019-04-28T04:55:24.980Z

That’s odd, since I’m purposefully setting every Peds Max Health to 100 upon creation, so that shouldn’t be the issue,

And yes, this is 100% a client script

Edit: I should clarify that everything else works fine, it’s just the function call for GetPedSourceOfDeath that’s causing issues.

blcd · 2019-04-28T05:17:31.349Z

ValonGP:

That’s odd, since I’m purposefully setting every Peds Max Health to 100 upon creation, so that shouldn’t be the issue,

I was just stating what I had to change to get the snippet to work locally.

ValonGP:

And yes, this is 100% a client script

Edit: I should clarify that everything else works fine, it’s just the function call for GetPedSourceOfDeath that’s causing issues.

Anyways looking at GetPedSourceOfDeath, it was renamed from GetPedKiller at some point so you are likely using an old manifest version. Make sure you have resource_manifest_version '44febabe-d386-4d18-afbe-5e627f4af937' in __resource.lua

ValonGP · 2019-04-28T05:41:07.658Z

Thaaat was it!

Minus having to now fix my Safezone checks due to that also being changed with the manifest changes, it works fine now.

Thank you very much for the assistance there

AhmedChaouch · 2020-10-26T12:56:06.072Z

hey guys , i have a problem with this code …

Citizen.CreateThread(function()
	while true do
		Citizen.Wait(500)
		local x,y,z = table.unpack(GetEntityCoords(GetPlayerPed(-1), true))
		local nearby = {}
		for _,ped in pairs(GetNearbyPeds(x,y,z,100.0)) do
			if DoesEntityExist(ped) and IsPedDeadOrDying(ped, 1) then
				if GetPedSourceOfDeath(ped) == GetPlayerPed(-1) then
					exports.XNLRankBar:Exp_XNL_AddPlayerXP(100)
					TriggerServerEvent('AddXp', 100)
				end
			end
		end
	end
end)

i am making a zombie server and i can’t figure out how to make players gain xp from killing zombies
( i have xnlrank bar in my server which is working perfectly with these two lines that make players earn xp )

exports.XNLRankBar:Exp_XNL_AddPlayerXP(100)
TriggerServerEvent(‘AddXp’, 100)