[RELEASE][LUA] ESX Deliveries REMAKE

Berk_Eratay · June 5, 2020, 2:44pm

Solved thanks

tif · June 8, 2020, 12:24pm

No, you don’t have to.

You want to fix the job, the main problem is vehicle spawning.

Replace function

AddEventHandler('esx_deliveries:startJob:client', function(deliveryType)

with

AddEventHandler('esx_deliveries:startJob:client', function(deliveryType)

	local spawned = SpawnDeliveryVehicle(deliveryType)
	if spawned then
		TriggerEvent("MpGameMessage:send", _U("delivery_start"), _U("delivery_tips"), 3500, 'success')
		LoadWorkPlayerSkin(deliveryType)
		local ModelHash = GetHashKey("prop_paper_bag_01")
		WaitModelLoad(ModelHash)
		CreateRoute(deliveryType)
		GetNextDeliveryPoint(true)
		CurrentType   = deliveryType
		CurrentStatus = Status.PLAYER_STARTED_DELIVERY
	end

end)

And replace
```function SpawnDeliveryVehicle(deliveryType)````
with

function SpawnVehicle(SpawnLocation, deliveryType)

	if deliveryType == 'scooter' then
		local ModelHash = GetHashKey(Config.Models.scooter)
		WaitModelLoad(ModelHash)
		-- CurrentVehicle = CreateVehicle(ModelHash, SpawnLocation.x, SpawnLocation.y, SpawnLocation.z, SpawnLocation.h, true, true)
		ESX.Game.SpawnVehicle(ModelHash, vector3(SpawnLocation.x, SpawnLocation.y, SpawnLocation.z), SpawnLocation.h, function(spawnedVehicle)
			CurrentVehicle = spawnedVehicle
			async_Finish_VehicleSpawn(deliveryType)
		end)
	end
	
	if deliveryType == 'truck' then
		local ModelHash = GetHashKey(Config.Models.truck)
		WaitModelLoad(ModelHash)
		--CurrentVehicle = CreateVehicle(ModelHash, SpawnLocation.x, SpawnLocation.y, SpawnLocation.z, SpawnLocation.h, true, true)
		ESX.Game.SpawnVehicle(ModelHash, vector3(SpawnLocation.x, SpawnLocation.y, SpawnLocation.z), SpawnLocation.h, function(spawnedVehicle)
			CurrentVehicle = spawnedVehicle
			async_Finish_VehicleSpawn(deliveryType)
		end)
		SetVehicleLivery(CurrentVehicle, 2)
	end
	
	if deliveryType == 'van' then
		local ModelHash = GetHashKey(Config.Models.van)
		WaitModelLoad(ModelHash)
		--CurrentVehicle = CreateVehicle(ModelHash, SpawnLocation.x, SpawnLocation.y, SpawnLocation.z, SpawnLocation.h, true, true)
		ESX.Game.SpawnVehicle(ModelHash, vector3(SpawnLocation.x, SpawnLocation.y, SpawnLocation.z), SpawnLocation.h, function(spawnedVehicle)
			CurrentVehicle = spawnedVehicle
			async_Finish_VehicleSpawn(deliveryType)
		end)
		SetVehicleExtra(CurrentVehicle, 2, false)
		SetVehicleLivery(CurrentVehicle, 0)
		SetVehicleColours(CurrentVehicle, 0, 0)
	end

	return CurrentVehicle

end

function SpawnDeliveryVehicle(deliveryType)
	
	local Rnd           = GetRandomFromRange(1, #Config.ParkingSpawns)
	local SpawnLocation = Config.ParkingSpawns[Rnd]

	local max_tries = #Config.ParkingSpawns

	while max_tries > -1 do
		Rnd = GetRandomFromRange(1, #Config.ParkingSpawns)
		SpawnLocation = Config.ParkingSpawns[Rnd]
		if ESX.Game.IsSpawnPointClear(vector3(SpawnLocation.x, SpawnLocation.y, SpawnLocation.z), 5.0) then
			SpawnVehicle(SpawnLocation, deliveryType)
			return true
		end
		max_tries = max_tries - 1
	end

	return false

end

function async_Finish_VehicleSpawn(deliveryType)
	DecorSetInt(CurrentVehicle, "Delivery.Rental", Config.DecorCode)
	SetVehicleOnGroundProperly(CurrentVehicle)

	if deliveryType == 'scooter' then
		local ModelHash = GetHashKey("prop_med_bag_01")
		WaitModelLoad(ModelHash)
		local Object = CreateObject(ModelHash, SpawnLocation.x, SpawnLocation.y, SpawnLocation.z, true, false, false)
		AttachEntityToEntity(Object, CurrentVehicle, GetEntityBoneIndexByName(CurrentVehicle, "misc_a"), 0.0, -0.55, 0.45, 0.0, 0.0, 0.0, true, true, false, true, 0, true)
		table.insert(CurrentVehicleAttachments, Object)
	end
	
	if deliveryType == 'van' then
		local ModelHash1 = GetHashKey("prop_crate_11e")
		local ModelHash2 = GetHashKey("prop_cardbordbox_02a")
		WaitModelLoad(ModelHash1)
		WaitModelLoad(ModelHash2)
		local Object1 = CreateObject(ModelHash1, SpawnLocation.x, SpawnLocation.y, SpawnLocation.z, true, false, false)
		local Object2 = CreateObject(ModelHash1, SpawnLocation.x, SpawnLocation.y, SpawnLocation.z, true, false, false)
		local Object3 = CreateObject(ModelHash2, SpawnLocation.x, SpawnLocation.y, SpawnLocation.z, true, false, false)
		AttachEntityToEntity(Object1, CurrentVehicle, GetEntityBoneIndexByName(CurrentVehicle, "chassic"), 0.25, -1.55, -0.12, 0.0, 0.0, 0.0, true, true, false, true, 0, true)
		AttachEntityToEntity(Object2, CurrentVehicle, GetEntityBoneIndexByName(CurrentVehicle, "chassic"), -0.26, -1.55, 0.2, 0.0, 0.0, 0.0, true, true, false, true, 0, true)
		AttachEntityToEntity(Object3, CurrentVehicle, GetEntityBoneIndexByName(CurrentVehicle, "chassic"), -0.26, -1.55, -0.12, 0.0, 0.0, 0.0, true, true, false, true, 0, true)
		table.insert(CurrentVehicleAttachments, Object1)
		table.insert(CurrentVehicleAttachments, Object2)
		table.insert(CurrentVehicleAttachments, Object3)
	end
end

To fix VAN spawning change config

--van     = 's1',
truck   = 'mule',

This is enough to fix the job. btw thanks for release, it’s really great.

P.S. You want to finish modification to cancel the fee if vehicle was not able to spawn.

zezad · June 17, 2020, 8:42pm

I’m having the same issue. Can you share the solution?

Berk_Eratay · June 18, 2020, 4:18am

-- Spawn the scooter, truck or van

function SpawnDeliveryVehicle(deliveryType)
	
	local Rnd           = GetRandomFromRange(1, #Config.ParkingSpawns)
	local SpawnLocation = Config.ParkingSpawns[Rnd]
	
	if deliveryType == 'scooter' then
		local ModelHash = GetHashKey(Config.Models.scooter)
		WaitModelLoad(ModelHash)
		CurrentVehicle = CreateVehicle(ModelHash, SpawnLocation.x, SpawnLocation.y, SpawnLocation.z, SpawnLocation.h, true, true)
		exports["LegacyFuel"]:SetFuel(CurrentVehicle, 100)
	end
	
	if deliveryType == 'truck' then
		local ModelHash = GetHashKey(Config.Models.truck)
		WaitModelLoad(ModelHash)
		CurrentVehicle = CreateVehicle(ModelHash, SpawnLocation.x, SpawnLocation.y, SpawnLocation.z, SpawnLocation.h, true, true)
		SetVehicleLivery(CurrentVehicle, 2)
		exports["LegacyFuel"]:SetFuel(CurrentVehicle, 100)
	end
	
	if deliveryType == 'van' then
		local ModelHash = GetHashKey(Config.Models.van)
		WaitModelLoad(ModelHash)
		CurrentVehicle = CreateVehicle(ModelHash, SpawnLocation.x, SpawnLocation.y, SpawnLocation.z, SpawnLocation.h, true, true)
		SetVehicleExtra(CurrentVehicle, 2, false)
		SetVehicleLivery(CurrentVehicle, 0)
		SetVehicleColours(CurrentVehicle, 0, 0)
		exports["LegacyFuel"]:SetFuel(CurrentVehicle, 100)
	end
	
	DecorSetInt(CurrentVehicle, "Delivery.Rental", Config.DecorCode)
	SetVehicleOnGroundProperly(CurrentVehicle)
	
	if deliveryType == 'scooter' then
		local ModelHash = GetHashKey("prop_med_bag_01")
		WaitModelLoad(ModelHash)
		local Object = CreateObject(ModelHash, SpawnLocation.x, SpawnLocation.y, SpawnLocation.z, true, false, false)
		AttachEntityToEntity(Object, CurrentVehicle, GetEntityBoneIndexByName(CurrentVehicle, "misc_a"), 0.0, -0.55, 0.45, 0.0, 0.0, 0.0, true, true, false, true, 0, true)
		table.insert(CurrentVehicleAttachments, Object)
	end
	
	if deliveryType == 'van' then
		local ModelHash1 = GetHashKey("prop_crate_11e")
		local ModelHash2 = GetHashKey("prop_cardbordbox_02a")
		WaitModelLoad(ModelHash1)
		WaitModelLoad(ModelHash2)
		local Object1 = CreateObject(ModelHash1, SpawnLocation.x, SpawnLocation.y, SpawnLocation.z, true, false, false)
		local Object2 = CreateObject(ModelHash1, SpawnLocation.x, SpawnLocation.y, SpawnLocation.z, true, false, false)
		local Object3 = CreateObject(ModelHash2, SpawnLocation.x, SpawnLocation.y, SpawnLocation.z, true, false, false)
		AttachEntityToEntity(Object1, CurrentVehicle, GetEntityBoneIndexByName(CurrentVehicle, "chassic"), 0.25, -1.55, -0.12, 0.0, 0.0, 0.0, true, true, false, true, 0, true)
		AttachEntityToEntity(Object2, CurrentVehicle, GetEntityBoneIndexByName(CurrentVehicle, "chassic"), -0.26, -1.55, 0.2, 0.0, 0.0, 0.0, true, true, false, true, 0, true)
		AttachEntityToEntity(Object3, CurrentVehicle, GetEntityBoneIndexByName(CurrentVehicle, "chassic"), -0.26, -1.55, -0.12, 0.0, 0.0, 0.0, true, true, false, true, 0, true)
		table.insert(CurrentVehicleAttachments, Object1)
		table.insert(CurrentVehicleAttachments, Object2)
		table.insert(CurrentVehicleAttachments, Object3)
	end
end

Main. Lua Replace from line 451
It’s for Legacy Fuel Btw if it’s for ESX Native let me know i can take a look

zezad · June 18, 2020, 5:02am

Works perfectly, thank you very much. Do you think it’s possible to require a player to have driver licenses to work there?

Buddytohelpu · June 18, 2020, 6:42am

That’s my issue so far, been trying to fix it and can’t seem to figure out what it is

Berk_Eratay · June 18, 2020, 7:56pm

Yeah a check can be add.
We keep it that way because it creates an illegal situation for the cops to govern.

WFDon · June 27, 2020, 5:34pm

Hello everyone. I have some trouble - my van doesn’t open the back doors when I take goods

This is normal?

megapihar · July 8, 2020, 9:38pm

how do I change women’s clothing? I change in the config and nothing changes, I registered the place of women’s clothing for men and still dresses in women’s clothing

docburn · August 5, 2020, 6:16pm

Thank you for this script! i like it… and refuse to work with dll

sparticuzzz · September 12, 2020, 6:43am

Hey, did you manage to find a fix for this issue?

Goontje · October 23, 2020, 3:42pm

This is an awesome plugin! Welldone m8.

I think i have found a bug though.
my case: Im testing the scooter one, and when i arrive at my destination (on scooter) and the circle says: press e to collect your package i pressed to quick on E to collect, before i was completely off the scooter.
Now the option to grab (press E) is gone, but keeps saying that i have to pick my stuff from the scooter.

Maybe something you can look into.

Thanks

Sugee83 · November 23, 2020, 10:53am

Hi,how can I make it for an activity?I mean I don’t want to use it as a job in the job center,rather I would like to use it as a hobby.Thank you in advance!

MarceRewell · November 27, 2020, 1:28pm

How could you make the money go to a society and not to the employee?

ty in advence

FurmaZ · May 3, 2021, 11:06am

Hello how you hide blip so only person who do this job sees it?

Papa_Smerf_Vlog · October 27, 2021, 6:36pm

Hey, the vehicle isn’t spawning when I paying a deposit. Can you help me resolve this issue? I would be thankful for any help.

Bruuts · December 1, 2021, 12:52am

How to change the position of the marker at the back of the vehicle?
I have a larger “van” so the marker at the back is now in the vehicle and needs to come outside
I managed to move the probs to the back but changing the Y scale of the TrunkPos.y the blip goes al over the vehicle to the left and another time to the right.

JamesNicholsan · March 6, 2022, 5:09am

Hi I put this script in and its amazing but a day after putting it in the van one no longer spawns the van so the scooter and mule is fine but the van doesn’t spawn or start the mission.

I have resolved this issue but is there any way to make the text on screen smaller?

Hekar_09 · February 15, 2023, 6:48pm

Hi I can use this job without jobcenter ?