[Question] How to return server side value to client side script?

Shiroyo · 2019-05-11T14:34:39.548Z

Hello. I’m creating a pretty simple mission system for my server and I want to check if player has enough items in his inventory to succesfully complete the missions and otherwise just tell him to get more of these items.

client.lua

function FarmerMission2()
	local enoughItems = nil
	TriggerServerEvent('esx_missions:FarmerMission')
	TriggerEvent('LIFE_CL:Sound:PlayOnOne', 'demo', 0.0)
	if enoughItems then
		FarmerMissionStarted = false
		FarmerMissionEnded = true
		RemoveBlip(FarmerBlip2)
	end
end

server.lua

RegisterServerEvent('esx_missions:FarmerMission')
AddEventHandler('esx_missions:FarmerMission', function()
            
            local enoughItems = nil
            local _source = source
			local xPlayer = ESX.GetPlayerFromId(_source)
            local xMitem = xPlayer.getInventoryItem('wood')
           
			if xMitem.count < 10 then
				TriggerClientEvent("pNotify:SendNotification", _source, {
					layout = "bottomRight",
					text = "Musisz mieć przy sobie co najmniej 10 sztuk drewna",
					type = "info",
					theme = "gta",
					sounds = {
						sources = {"notification.wav"}, -- For sounds to work, you place your sound in the html folder and then add it to the files array in the __resource.lua file.
						volume = 0.2,
						conditions = {"docVisible"} -- This means it will play the sound when the notification becomes visible.
					}
                })
                    TriggerClientEvent('chat:addMessage', source, {
                        template = '<div style="padding: 0.5vw; margin: 0.5vw; background-color: rgba(0, 95, 0, 0.6); border-radius: 3px;"><i class="fas fa-child"></i> Frank Green: Tyle drewna nie wystarczy mi na dzisiejszą noc.</div>',
                        args = { fal, msg }
                    })
                enoughItems = false
			else
                xPlayer.removeInventoryItem('wood', 10)
                xPlayer.addInventoryItem('clip', 2)

				TriggerClientEvent("pNotify:SendNotification", _source, {
					layout = "bottomRight",
					text = "Przekazałeś mężczyźnie 10 sztuk drewna i otrzymałeś od niego 2 magazynki",
					type = "info",
					theme = "gta",
					sounds = {
						sources = {"notification.wav"}, -- For sounds to work, you place your sound in the html folder and then add it to the files array in the __resource.lua file.
						volume = 0.2,
						conditions = {"docVisible"} -- This means it will play the sound when the notification becomes visible.
					}
                })
                    TriggerClientEvent('chat:addMessage', source, {
                        template = '<div style="padding: 0.5vw; margin: 0.5vw; background-color: rgba(0, 95, 0, 0.6); border-radius: 3px;"><i class="fas fa-child"></i> Frank Green: Nawet nie wiesz jak bardzo jestem ci wdzięczny. Teraz już nie muszę się bać mroźnej nocy. Weź to. Myślę, że bardziej ci się przyda.</div>',
                        args = { fal, msg }
                    })
                enoughItems = true
			end

end)

How can I return enoughItems from server.lua to client.lua?

xander1998 · 2019-05-11T14:46:36.530Z

Pass the data with a client event.

Shiroyo · 2019-05-11T15:00:51.906Z

First time doing this so am I going to the right direction or that’s completely wrong?

server.lua

...
                    TriggerClientEvent('chat:addMessage', source, {
                        template = '<div style="padding: 0.5vw; margin: 0.5vw; background-color: rgba(0, 95, 0, 0.6); border-radius: 3px;"><i class="fas fa-child"></i> Frank Green: Nawet nie wiesz jak bardzo jestem ci wdzięczny. Teraz już nie muszę się bać mroźnej nocy. Weź to. Myślę, że bardziej ci się przyda.</div>',
                        args = { fal, msg }
                    })
                enoughItems = true
			end
		TriggerClientEvent('esx_missions:getData', source) --Where should I mention enoughItems?

end)

client.lua

function GetItemData(enoughItems)
		return enoughItems
end

function FarmerMission2()
	--local enoughItems = nil
	TriggerServerEvent('esx_missions:FarmerMission')
	TriggerEvent('LIFE_CL:Sound:PlayOnOne', 'demo', 0.0)
	if GetItemData(enoughItems) then
		FarmerMissionStarted = false
		FarmerMissionEnded = true
		RemoveBlip(FarmerBlip2)
	end
end

RegisterNetEvent('esx_missions:getData')
AddEventHandler('esx_missions:getData', function(enoughItems)
	GetItemData(enoughItems)
end)

xander1998 · 2019-05-11T15:06:04.951Z

Instead of using a method in the client event set a variable to assign it to. Also your items will be sent after source so it will be source, items)

Also every time your code on the client os done using the items I would set the items to null that way you have a way to wait until items is not null (meaning the server has set the items on the client.)

Shiroyo · 2019-05-11T15:34:13.493Z

I assume you meant enoughItems

TriggerClientEvent('esx_missions:getData', source, enoughItems)

I changed that but it still doesn’t return the values. Should I add something to EventHandler or GetItemData? By asigning variable you meant to just remove function GetItemData and do this?

RegisterNetEvent('esx_missions:getData')
AddEventHandler('esx_missions:getData', function(enoughItems)
	enoughitems = GetItemData(enoughItems)
end)

Sorry for a lot of newbish questions.

xander1998 · 2019-05-11T15:41:08.832Z

That doesn’t work like that. That GetItemData method is pretty much useless rn. No reason to have it at this point in your code.

RegisterNetEvent('esx_missions:getData')
AddEventHandler('esx_missions:getData', function(_enoughItems)
	enoughitems = _enoughItems
end)

Shiroyo · 2019-05-11T16:48:40.108Z

Thank you for all the tips. Should it work now? Because it seems that it still doesn’t pass the value.

client.lua

local enoughItems = nil

function FarmerMission2()
	TriggerServerEvent('esx_missions:FarmerMission')
	if enoughItems then
		--code
	else
		--code
	end
end

RegisterNetEvent('esx_missions:getData')
AddEventHandler('esx_missions:getData', function(_enoughItems)
	enoughitems = _enoughItems
end)

server.lua

RegisterServerEvent('esx_missions:FarmerMission')
AddEventHandler('esx_missions:FarmerMission', function()
            
            local _enoughItems = nil
            local _source = source

			if xMitem.count < 10 then
	            --code
				_enoughItems = false
			else
                --code
				_enoughItems = true
			end
		TriggerClientEvent('esx_missions:getData', source, _enoughItems)
end)

xander1998 · 2019-05-11T16:51:39.686Z

You will need to wait until enoughItems isn’t null

So before you trigger that FarmerMission2() method (or any method that requires that data

you can do while enoughItems == nil do Citizen.Wait(100) end

but make sure you have a thresh hold timer to make sure that while loop doesn’t go on forever.

Shiroyo · 2019-05-11T16:59:53.763Z

Something is still not right. No errors but still not passing value from server.lua.

client.lua

-- Key Controls
Citizen.CreateThread(function()
while true do

	Citizen.Wait(10)

	if CurrentAction ~= nil then

		SetTextComponentFormat('STRING')
		AddTextComponentString(CurrentActionMsg)
		DisplayHelpTextFromStringLabel(0, 0, 1, -1)

		if IsControlPressed(0,  Keys['E']) and (GetGameTimer() - GUI.Time) > 150 then

			if CurrentAction == 'Farmer2' then
				TriggerServerEvent('esx_missions:FarmerMission')
				while enoughItems == nil do 
					Citizen.Wait(100) 
				end
				FarmerMission2()
			end
			
			CurrentAction = nil
			GUI.Time      = GetGameTimer()
			
		end

	end

end
end)

function FarmerMission2()
	if enoughItems then
		FarmerMissionStarted = false
		FarmerMissionEnded = true
		RemoveBlip(FarmerBlip2)
		TriggerEvent('LIFE_CL:Sound:PlayOnOne', 'demo', 0.0)
		if GetDistanceBetweenCoords(GetEntityCoords(GetPlayerPed(myId)), GetEntityCoords(GetPlayerPed(pid)), true) < 19.999 then
			TriggerEvent('chat:addMessage', {
				template = '<div style="padding: 0.5vw; margin: 0.5vw; background-color: rgba(0, 95, 0, 0.6); border-radius: 3px;"><i class="fas fa-child"></i> Farmer: Yes.</div>',
				args = { name, message }
		})
		end
	else
		if GetDistanceBetweenCoords(GetEntityCoords(GetPlayerPed(myId)), GetEntityCoords(GetPlayerPed(pid)), true) < 19.999 then
			TriggerEvent('chat:addMessage', {
				template = '<div style="padding: 0.5vw; margin: 0.5vw; background-color: rgba(0, 95, 0, 0.6); border-radius: 3px;"><i class="fas fa-child"></i> Farmer: No.</div>',
				args = { name, message }
		})
		end
	end
end

xander1998 · 2019-05-11T17:01:14.726Z

Well start with the server then and debug the data. Also debug the data in the client event to see if it is being passed.

Shiroyo · 2019-05-11T17:12:18.546Z

I see that it doesn’t pass the value because the loop never ends and and it just keeps the value I initiated it with in the beginning at the top of the client.lua - local enoughItems = nil. So only if I change it there to true or false, the enoughItems is not null. No information about anything in the server console (CMD) and client console (F8)

xander1998 · 2019-05-11T17:15:18.793Z

Well if the data is never being set then maybe the server is passing nil instead of it setting it to true or false?

maybe try this for the server event

RegisterServerEvent('esx_missions:FarmerMission')
AddEventHandler('esx_missions:FarmerMission', function()
		local _enoughItems = false
		local _source = source
		if xMitem.count >= 10 then
			_enoughItems = true
		end
		TriggerClientEvent('esx_missions:getData', _source, _enoughItems)
end)

Shiroyo · 2019-05-11T17:20:32.398Z

Hmm, still not working. It seems that it doesn’t even read anything from server.lua. But if I insert some other things like removing some items from player inventory it does work so something is still wrong with passing the value to client.lua

if xMitem.count >= 10 then
    xPlayer.removeInventoryItem('wood', 10)
    xPlayer.addInventoryItem('clip', 2)
    _enoughItems = true
end

xander1998 · 2019-05-11T17:21:23.771Z

put a print message in the client event to see if it is even being triggered.

Shiroyo · 2019-05-11T17:30:30.411Z

Okay so it seems to not even being trigged. I put print and I see nothing in the console.

RegisterNetEvent('esx_missions:getData')
AddEventHandler('esx_missions:getData', function(_enoughItems)
	enoughitems = _enoughItems
	print("It's working")
end)

xander1998 · 2019-05-11T17:34:38.539Z

I mean I don’t see anything that could be causing it not to trigger unless for some reason that _source and source isn’t correct which I wouldn’t understand why.

Shiroyo · 2019-05-11T17:38:48.981Z

Yeah, it’s strange if something is wrong with _source/source because

TriggerClientEvent("pNotify:SendNotification", _source, {
					layout = "bottomRight",
					text = "Przekazałeś mężczyźnie 10 sztuk drewna i otrzymałeś od niego 2 magazynki",
					type = "info",
					theme = "gta",
					sounds = {
						sources = {"notification.wav"}, -- For sounds to work, you place your sound in the html folder and then add it to the files array in the __resource.lua file.
						volume = 0.2,
						conditions = {"docVisible"} -- This means it will play the sound when the notification becomes visible.
					}
                })

works good with _source in the same place.

xander1998 · 2019-05-11T18:01:35.844Z

Yeah very weird. Maybe someone else will jump in here and spot something I didn’t.

Shiroyo · 2019-05-11T18:16:18.588Z

But still many thanks for tons of useful informations

xander1998 · 2019-05-11T18:17:11.493Z

Your welcome.