Need Help With Adding a Function to a Script!

PeterGreek · 2019-03-24T06:04:34.524Z

So I have been trying to edit this script that I found. I know very little in LUA and code in general so I am kinda stuck. I am trying to make it so this chop shop script gives me back Items instead of money.

client.lua

local randomVehicles = {
    {model = "ADDER", label = "Adder"},
    --{model = "SANDKING", label = "Sandking", price = 8},
    --{model = "LANDSTAL", label = "Landstalker", price = 10},
    --{model = "SUPERDIAMOND", label = "Superdiamond", price = 9},
    --{model = "SABREGT", label = "Sabre GT", price = 9},
    {model = "PANTO", label = "Panto"}
    -- Add more vehicles you want.
}

local chopShopLocations = {
    {x = 480.47, y = -1317.82, z = 29.2}
    -- Add More if you want :D
}
	
local timer = false
local selectRandomVehicle = nil
Citizen.CreateThread(function()
    for _, item in pairs(chopShopLocations) do
		item.blip = AddBlipForCoord(item.x, item.y, item.z)
		SetBlipSprite(item.blip, 72)
		SetBlipColour(item.blip, 1)
		SetBlipScale(item.blip, 0.8)
		SetBlipAsShortRange(item.blip, true)
		BeginTextCommandSetBlipName("STRING")
		AddTextComponentString("Chop Shop")
		EndTextCommandSetBlipName(item.blip)
	end
    while true do
        Citizen.Wait(1)
        for a = 1, #chopShopLocations do
            local ped = GetPlayerPed(PlayerId())
            local pedPos = GetEntityCoords(ped, false)
            local distance = Vdist(pedPos.x, pedPos.y, pedPos.z, chopShopLocations[a].x, chopShopLocations[a].y, chopShopLocations[a].z)
            local vehicle = IsPedInAnyVehicle(ped, false)
            if distance <= 30.0 then
                    DrawMarker(1, chopShopLocations[a].x, chopShopLocations[a].y, chopShopLocations[a].z - 1, 0, 0, 0, 0, 0, 0, 3.0001, 3.0001, 0.5001, 1555, 0, 0,165, 0, 0, 0,0)
                if distance <= 2.0 then
                    if not timer then
                        drawText('Press ~r~E~s~ to get a Vehicle to find!',0,1,0.5,0.8,0.6,255,255,255,255)
                        if IsControlJustPressed(1, 86) then
                            selectRandomVehicle = randomVehicles[math.random(1, #randomVehicles)]
                            Countdown = GetGameTimer() + 5 * 1000
                            timer = true
                            TriggerEvent('chatMessage', 'Chop Shop', {255, 123, 0}, "^4Find the Chop Shop a "..selectRandomVehicle.label.."")
                        end
                    elseif timer and vehicle ~= false then
                        drawText('Press ~r~E~s~ to Chop Vehicle',0,1,0.5,0.8,0.6,255,255,255,255)
                        local currentVeh = GetDisplayNameFromVehicleModel(GetEntityModel(GetVehiclePedIsUsing(GetPlayerPed(PlayerId()))))
                        if IsControlJustPressed(1, 86) then
                            if currentVeh == selectRandomVehicle.model then
                                selectRandomVehicle = nil
                                timer = false
                                TriggerServerEvent("Darkzy:PayDeManPlz", selectRandomVehicle)
                                local vehicleIn = GetVehiclePedIsUsing(ped)
                                deleteCar(vehicleIn)
                            else
                                TriggerEvent("ISRP_Notification:Error", "Chop Shop", "This is not the right Vehicle", 5000, false, "leftCenter")
                            end
                        end
                    elseif timer then
                        local secsRemaining = math.ceil((Countdown - GetGameTimer()) / 1000)
                        secsRemaining = secsRemaining - 1
                        if secsRemaining > 0 then
                            drawText('Please wait ~r~'..secsRemaining..'~w~ until you can get a new Vehicle',0,1,0.5,0.8,0.6,255,255,255,255)
                        else
                            timer = false
                            print(timer)
                        end
                    end
                end
            end
        end
    end
end)

function deleteCar( vehicle )
	Citizen.InvokeNative( 0xEA386986E786A54F, Citizen.PointerValueIntInitialized( vehicle ) )
end

function drawText(text,font,centre,x,y,scale,r,g,b,a)
    SetTextFont(font)
	SetTextProportional(0)
	SetTextScale(scale, scale)
	SetTextColour(r, g, b, a)
	SetTextDropShadow(0, 0, 0, 0,255)
	SetTextEdge(1, 0, 0, 0, 255)
	SetTextDropShadow()
	SetTextOutline()
	SetTextCentre(centre)
	SetTextEntry("STRING")
	AddTextComponentString(text)
    DrawText(x , y)
end

server.lua

ESX = nil

RegisterServerEvent("Darkzy:PayDeManPlz")
AddEventHandler("Darkzy:PayDeManPlz", function(source)
	local _source = source
	local xPlayer = ESX.GetPlayerFromId(_source)
	local ???? = xPlayer.getInventoryItem('screw')
		then				
			xPlayer.addInventoryItem('screw', 5)

			end

		end
    end)
end

Thanks in advance!

PeterGreek · 2019-03-24T06:07:22.338Z

(Note that this is my edited version not the working version that gives you money, this is what I have attempted but not giving me the item ‘screw’)

WiZ.Gaming · 2019-03-24T06:29:31.067Z

Hey @PeterGreek

I’m not used to develop in ESX, but try to replace server.lua for:

ESX = nil

RegisterServerEvent("Darkzy:PayDeManPlz")
AddEventHandler("Darkzy:PayDeManPlz", function(source)
	local _source = source
	local xPlayer = ESX.GetPlayerFromId(_source)
	xPlayer.addInventoryItem('screw', 5)
end)

I think you have deleted some if statements and messed up with the “ends”.

Hope this helps you

PeterGreek · 2019-03-24T06:37:58.416Z

Thanks for the response unfortunately that did not fix the issue for some reason no errors occur so I have no idea either how to fix this.

WiZ.Gaming · 2019-03-24T06:43:56.895Z

Well, as I said I’m not used to work in ESX scripts.
Can you link the original script so I can try to change it in the way you want?

PeterGreek · 2019-03-24T06:48:08.835Z

@WiZ.Gaming Here it is [Release] Chopshop (Sell randomly selected Vehicles, for money)

WiZ.Gaming · 2019-03-24T06:59:42.639Z

I looked to the code itself, unfortunately as I already said I don’t work with ESX, only with vRP and I can’t help you.
Hope you find the solution!

PeterGreek · 2019-03-25T20:23:11.408Z

@WiZ.Gaming Thanks for the help I found a way to fix it in case you were wondering.

RegisterServerEvent("sellVehicle")
AddEventHandler("sellVehicle", function(vehPrice)
	local _source = source
	local xPlayer = ESX.GetPlayerFromId(_source)
	xPlayer.addInventoryItem('screw', vehPrice)
	CancelEvent()
end)

WiZ.Gaming · 2019-03-25T23:05:39.452Z

Good job

KingAlmond · 2019-04-27T09:23:24.945Z

PeterGreek:

ESX = nil

how did u make this work exactly, im trying and it wont work.