Well yeah, they need your public IP to connect to the server, unless they are physically on your network…
Putting in your machine IP on your router/modem for port forwarding opens up your public IP to that port for others to see/connect too.