Is there a difference between GetClosestVehicle & ESX.Game.GetClosestVehicle?

VirtualJunky · 2019-05-08T21:35:08.835Z

I’m writing a PDM script and I notice on a decent amount of cars GetClosestVehicle returns nothing, I saw in the documentation that this is a known thing. I was curious if ESX.Game.GetClosestVehicle is any different, and what does it return? The ESX documentation just shows the input.

Just wondering if it’s even worth the effort of ripping up my script to change everything to ESX.Game or if I need to find a different option.

TheIndra · 2019-05-08T21:38:07.825Z

The code of ESX’s getclosestvehicle function can be viewed in the repo

github.com

ESX-Org/es_extended/blob/3d27e2b0a67873422d77365089faf53cfa7ea888/client/functions.lua#L547-L566


ESX.Game.GetClosestVehicle = function(coords)
	local vehicles        = ESX.Game.GetVehicles()
	local closestDistance = -1
	local closestVehicle  = -1
	local coords          = coords


	if coords == nil then
		local playerPed = PlayerPedId()
		coords          = GetEntityCoords(playerPed)
	end


	for i=1, #vehicles, 1 do
		local vehicleCoords = GetEntityCoords(vehicles[i])
		local distance      = GetDistanceBetweenCoords(vehicleCoords, coords.x, coords.y, coords.z, true)


		if closestDistance == -1 or closestDistance > distance then
			closestVehicle  = vehicles[i]
			closestDistance = distance
		end
	end

As you can see they pull all the vehicles in the world and then do a distance check to get the closestvehicle

VirtualJunky · 2019-05-08T22:45:30.593Z

Would this be more reliable then FiveM’s GetClosestVehicle? Or does it have the same faults?

FAXES · 2019-05-09T02:31:13.611Z

I’d use the native one if I were you This relies less on dependencies and should run better.

VirtualJunky · 2019-05-09T02:39:26.069Z

Well my issue is some vehicles, for example most off road vehicles return 0. I’d have to cut like 30% of the vehicles from PDM because GetClosestVehicle returns 0 so I was looking into other options. I know there is casting a ray in front of a player to get a car, I use that for my repair resource, but it doesn’t really work for this situation. I need to get the car at specific coords even if the player isn’t near it or looking at it reliably.

FAXES · 2019-05-09T02:41:46.907Z

VirtualJunky:

GetClosestVehicle

Try viewing this:

Cfx.re Native Reference

Documenting 7157 natives for GTA V and Cfx.re

TheIndra · 2019-05-09T05:54:25.432Z

This native can have some problems with some vehicles, that’s why he might wants to use the esx getclosestvehicle function (or atleast something based on it) (or check the snippet in the native ref for it)

VirtualJunky · 2019-05-09T11:28:49.647Z

After some playing around and debugging I found that it’s actually not GetClosestVehicle but what I was doing with the info that had the effect. Yesterday I was quite tired and just assumed GetClosestVehicle was the culprit because of the comments on the native.

Thanks for the help both of you.

d0p3t · 2019-05-09T16:28:50.164Z