How to optimise this code?

Rubylium · 2019-08-03T18:50:21.232Z

Hi there, i did some test to optimise this code for an server with 128 players connected, but could not found out how.
Someone with beter knowledge than me could help me on this one ?

Citizen.CreateThread(function()
	while true do
		Citizen.Wait(0)
		for _, id in ipairs(GetActivePlayers()) do
			if  ((NetworkIsPlayerActive( id )) and GetPlayerPed( id ) ~= GetPlayerPed( -1 )) then
				ped = GetPlayerPed( id )


				x1, y1, z1 = table.unpack( GetEntityCoords( GetPlayerPed( -1 ), true ) )
				x2, y2, z2 = table.unpack( GetEntityCoords( GetPlayerPed( id ), true ) )
				distance = math.floor(GetDistanceBetweenCoords(x1,  y1,  z1,  x2,  y2,  z2,  true))


				if ((distance < playerNamesDist) and IsEntityVisible(GetPlayerPed(id))) ~= GetPlayerPed( -1 ) then
					if NetworkIsPlayerTalking(id) then
						DrawMarker(25,x2,y2,z2 - 0.95, 0, 0, 0, 0, 0, 0, 1.0, 1.0, 10.3, 55, 160, 205, 105, 0, 0, 2, 0, 0, 0, 0)
					end
				end 
			end
		end
	end
end)

Thanks

IDKFORCE · 2024-07-25T13:36:17.995Z

there ofc others ways to optimize this even better

CreateThread(function()
    local playerPed = PlayerPedId()

    while true do
        Wait(0)
        local playerCoords = GetEntityCoords(playerPed, true)

        for _, id in ipairs(GetActivePlayers()) do
            if NetworkIsPlayerActive(id) then
                local targetPed = GetPlayerPed(id)
                if targetPed ~= playerPed then
                    local targetCoords = GetEntityCoords(targetPed, true)
                    local distance = #(playerCoords - targetCoords)

                    if distance < playerNamesDist and IsEntityVisible(targetPed) then
                        if NetworkIsPlayerTalking(id) then
                            DrawMarker(25, targetCoords.x, targetCoords.y, targetCoords.z - 0.95, 0, 0, 0, 0, 0, 0, 1.0,
                                1.0, 10.3, 55, 160, 205, 105, 0, 0, 2, 0, 0, 0, 0)
                        end
                    end
                end
            end
        end
    end
end)

STACHY225 · 2024-07-25T14:17:15.597Z

Pss GetActivePlayers returns all Active players, so theres no reason to check if player is active

Rubylium · 2024-07-25T14:35:56.632Z

Why are you guys responding to a post from 5 years ago ? 0_0

Also doing this

Is bad as if for any reason your ped change, your code will just not work anymore.
If for any reason people want to know how to make this optimised now 5 years later, just make 2 thread. 1 slow handling the positions checks ( something like every 1-2s depending on the use case is fine ), and an other more fast one handling the draw only that should be slowed down when no one is NetworkIsPlayerTalking.

TheIndra · 2024-07-25T15:37:55.001Z