[HELP] Vehicle siren issue on server side

lowheartrate · 2019-05-15T02:55:14.681Z

Yes - resource_manifest_version '44febabe-d386-4d18-afbe-5e627f4af937'

Radbug · 2019-05-15T02:56:07.496Z

i have no idea then

Radbug · 2019-05-15T03:00:56.249Z

PlayerPedId() works on the client side right?

try this

in client:

local ped = PlayerPedId()
TriggerServerEvent(‘codeTwo’, ped)

in server:


RegisterServerEvent('codeTwo')
AddEventHandler('codeTwo', function(clientPed)
             local ped = clientPed

Radbug · 2019-05-15T03:02:35.186Z

jesus I just realized what you are trying to send is the state of the vehicles lights/siren right? hehe we actually need to be sending the VEHICLE through, not the player ped

will also need to send the vehicle back tot he client when you update clients at the end of the server event

lowheartrate · 2019-05-15T03:04:18.659Z

Yes I am trying to set it so it updates for all the players (no siren sound) because as of right now with the code I originally posted, it turns siren sound off for only the client that called the event.

Radbug · 2019-05-15T03:11:03.261Z

so…

client:


Citizen.CreateThread(function()
    while true do
        Citizen.Wait(0)
              -- if player hits 'LCTRL + 2' - set police car to code 2
		if IsControlPressed(0, Keys['LEFTCTRL']) and IsControlJustPressed(0, Keys['2']) then 
			local ped = PlayerPedId()
			local vehicle = GetVehiclePedIsIn(ped, false)
			local class = GetVehicleClass(vehicle)
			
			if vehicle ~= 0 then
				if class == 18 then 
					
					TriggerServerEvent('codeTwo', vehicle)
					ShowNotification("You've entered ~y~code two~w~.")
				end
			end

			
		end
    end
end)

-- code two --
RegisterNetEvent('codeTwo')
AddEventHandler('codeTwo', function(vehicle)
	SetVehicleSiren(vehicle, true)
	DisableVehicleImpactExplosionActivation(vehicle, true)
	
end)
--------------

server:


RegisterServerEvent('codeTwo')
AddEventHandler('codeTwo', function(vehicle)
            
                local players = GetPlayers()
                for _,player in pairs(players) do
                    TriggerClientEvent('codeTwo', player, vehicle)
                    
                    --print("sent to player: " .. player)
                end
end)

(edited to move notification to just the client who presses the key)

Radbug · 2019-05-15T03:14:26.543Z

actually the notification should probably still be in the client thread after the TriggerServerEvent

lowheartrate · 2019-05-15T03:15:32.573Z

Radbug:

so…

client:

Worked great, thank you. Do I need to adjust the location of the ShowNotification? Seems to notify me just fine and set code two’s for the players vehicle great!

Radbug · 2019-05-15T03:26:36.224Z

if you leave it in the event that is called for all players, then all player will get the notification

lowheartrate · 2019-05-15T03:27:39.885Z

Right, so its in the

-- code two --
RegisterNetEvent('codeTwo')
AddEventHandler('codeTwo', function(vehicle)
	SetVehicleSiren(vehicle, true)
	DisableVehicleImpactExplosionActivation(vehicle, true)
					
	ShowNotification("You've entered ~y~code two~w~.")
end)
--------------

Where is it that it should go?

Radbug · 2019-05-15T03:28:51.580Z

right after

Radbug:

TriggerServerEvent(‘codeTwo’, vehicle)

is probably best

lowheartrate · 2019-05-15T03:30:08.024Z

Gotcha, thank you!

Radbug · 2019-05-15T03:30:39.928Z

glad i could help

lowheartrate · 2019-05-16T01:43:23.258Z

Got it tested and working on my server for codeTwo but tried to do the same server event with codeThree but doesn’t seem to do anything at all including turning on the lights at all. I tried to set it as just a client event but run into the issue where other players cannot hear the siren again so I used the codeTwo we did as a template and did the same method but it doesn’t set the siren sound for even me. I get 0 errors in the F8 Console and still get the ShowNotification("You've entered ~y~code three~w~.").

client.lua

-- code three --
RegisterNetEvent('codeThree')
AddEventHandler('codeThree', function()
	-- for server event -- 
    SetVehicleSiren(vehicle, true)
    DisableVehicleImpactExplosionActivation(vehicle, false)
end)

Citizen.CreateThread(function()
    while true do
      Citizen.Wait(0)
      
      -- if player hits 'LCTRL + 3' - set police car to code 3
      if IsControlPressed(0, Keys['LEFTCTRL']) and IsControlJustPressed(0, Keys['3']) then 
	    local player = PlayerPedId()
	    local vehicle = GetVehiclePedIsIn(player, false)
	    local class = GetVehicleClass(vehicle)
	
	    if vehicle ~= 0 then 
		  if class == 18 then 
		    TriggerServerEvent('codeThree', vehicle)
		    ShowNotification("You've entered ~y~code three~w~.")
		  end 
	    end 
      end

    end
end)

server.lua

-- toggle code three --
RegisterServerEvent('codeThree')
AddEventHandler('codeThree', function(vehicle)
	local players = GetPlayers()
	for _,player in pairs(players) do
		TriggerClientEvent('codeThree', player, vehicle)
		
		--print("sent to player: " .. player)
	end
end)
-----------------------

Radbug · 2019-05-19T09:15:33.990Z

looking at that code it looks like it should all work. must be something really minor

the best thing to do is insert some print() functions to see where the code stops working.
start by uncommenting the print function in the server
and add a print function in the client event as well so you can see if it gets back to the client

lowheartrate · 2019-05-19T16:46:36.824Z

It actually seems to be real broken at the moment. I had it in my server last night and when I toggled code two/three, it changed the siren control for another player and didn’t touch mine although it gave me the notification. I have uploaded the project to my GitHub so you can easily see what my code looks like if you don’t mind taking a look? https://github.com/lowheartrate/vehicleController. In the meantime, i’ll go about using print() to see where it stops working properly.

Radbug · 2019-05-19T21:11:30.743Z

in the code you put on github, for the codeTwo and codeThree client events you have them finding new targets without having a source.

-- code two --
RegisterNetEvent('codeTwo')
AddEventHandler('codeTwo', function(vehicle)
	local player = GetPlayerPed()
	local vehicle = GetVehiclePedIsIn(player, false)
	local class = GetVehicleClass(vehicle)
	-- turn on siren 
	SetVehicleSiren(vehicle, true)
	-- turn off siren (sound)
	DisableVehicleImpactExplosionActivation(vehicle, true)
end)
--------------

-- code three --
RegisterNetEvent('codeThree')
AddEventHandler('codeThree', function()
	local player = GetPlayerPed()
	local vehicle = GetVehiclePedIsIn(player, false)
	local class = GetVehicleClass(vehicle)
	-- for server event -- 
	SetVehicleSiren(vehicle, true)
	DisableVehicleImpactExplosionActivation(vehicle, false)

the vehicle is already determined and being sent along tot he server and back tot he client, so you dont want to try to find a new one.

the code should look like:

-- code two --
RegisterNetEvent('codeTwo')
AddEventHandler('codeTwo', function(vehicle)
	-- turn on siren 
	SetVehicleSiren(vehicle, true)
	
	DisableVehicleImpactExplosionActivation(vehicle, true)
end)
--------------

-- code three --
RegisterNetEvent('codeThree')
AddEventHandler('codeThree', function()
	-- turn on siren
	SetVehicleSiren(vehicle, true)
	DisableVehicleImpactExplosionActivation(vehicle, false)
end)

of course I realize now this code will only make the lights turn on, not off.

to make it toggle:

-- code two --
RegisterNetEvent('codeTwo')
AddEventHandler('codeTwo', function(vehicle)
	if IsVehicleSirenOn(vehicle) then
              SetVehicleSiren(vehicle, false)
        else
	          SetVehicleSiren(vehicle, true)
        end
	
	DisableVehicleImpactExplosionActivation(vehicle, true)
end)
--------------

-- code three --
RegisterNetEvent('codeThree')
AddEventHandler('codeThree', function()
	if IsVehicleSirenOn(vehicle) then
              SetVehicleSiren(vehicle, false)
        else
	          SetVehicleSiren(vehicle, true)
        end
	DisableVehicleImpactExplosionActivation(vehicle, false)
end)

also in the Citizen thread you might want to check for toggle as well:


		-- if player hits 'LCTRL + 2' - set police car to code 2
		if IsControlPressed(0, Keys['LEFTCTRL']) and IsControlJustPressed(0, Keys['2']) then 
			-- set variables 
			local player = PlayerPedId()
			local vehicle = GetVehiclePedIsIn(player, false)
			local class = GetVehicleClass(vehicle)
			
			-- if player is in a vehicle 
			if vehicle ~= 0 then 
				-- if vehicle ped is in, is an emergency vehicle 
				if class == 18 then 
					-- trigger codeTwo server event
					TriggerServerEvent('codeTwo', vehicle)
					-- give user notification
                                       if IsVehicleSirenOn(vehicle) then
                                           ShowNotification("You've canceled ~y~code two~w~.")
                                       else
	                                       ShowNotification("You've entered ~y~code two~w~.")
                                       end
					
				end
			end
		end
		
		-- if player hits 'LCTRL + 3' - set police car to code 3
		if IsControlPressed(0, Keys['LEFTCTRL']) and IsControlJustPressed(0, Keys['3']) then 
			local player = PlayerPedId()
			local vehicle = GetVehiclePedIsIn(player, false)
			local class = GetVehicleClass(vehicle)
			
			if vehicle ~= 0 then 
				if class == 18 then 
					TriggerServerEvent('codeThree', vehicle)
                                        if IsVehicleSirenOn(vehicle) then
                                           ShowNotification("You've canceled ~y~code three~w~.")
                                       else
	                                       ShowNotification("You've entered ~y~code three~w~.")
                                       end
				end 
			end 
		end

lowheartrate · 2019-05-19T22:17:13.150Z

hmm okay, I’ve updated the github project with the code but when the player hits code two it actually runs sirens for the other player(s) but it works fine client-sided. Also code three’s don’t seem to run at all

Radbug · 2019-05-20T08:25:59.480Z

you dont get any errors though?

Radbug · 2019-05-20T08:29:03.738Z

oh in codeThree even client side:

-- code three --
RegisterNetEvent('codeThree')
AddEventHandler('codeThree', function()

need to add vehicle

-- code three --
RegisterNetEvent('codeThree')
AddEventHandler('codeThree', function(vehicle)