[Help][C#]Command action

McFck · 2019-03-21T15:34:39.864Z

So I`m trying to make a saw to spawn by using command “/saw” but nothing happening when writing command.
(This one from the client folder)

 private async Task RetrieveSaw()
        {
            await LocalPlayer.Character.Task.PlayAnimation(AnimDict, AnimName, -8f, 8f, -1, AnimationFlags.StayInEndFrame | AnimationFlags.UpperBodyOnly | AnimationFlags.AllowRotation, 8f);
            Vector3 PlayerPos = LocalPlayer.Character.GetOffsetPosition(new Vector3(0f, 1f, 0f));
            CurrentSaw = await World.CreateProp(SawModel, PlayerPos, true, true);
            CurrentSawNetHandle = API.NetworkGetNetworkIdFromEntity(CurrentSaw.Handle);
            CurrentSaw.AttachTo(LocalPlayer.Character.Bones[Bone.SKEL_R_Hand], new Vector3(0.095f, 0f, 0f), new Vector3(125f, 155f, 55f));
        }
        private async Task CommandSpawnAsync()
        {
            API.RegisterCommand("saw", new Action<int, List<object>, string>(async (src, args, raw) =>
            {

                await RetrieveSaw();
            }), false);
            await Delay(100);
        }

VenomXNL · 2019-03-21T15:40:21.209Z

Just a “small tip”:

You seem to be calling RetrieveSaw (a different function).

But you didn’t posted that function here so no-one will be able to see what even happens when you call that function

You will need to post the code of that function to.

McFck · 2019-03-21T15:41:37.226Z

Edited

VenomXNL · 2019-03-21T15:43:22.674Z

CurrentSaw = await World.CreateProp(SawModel, PlayerPos, true, true);

You are creating a prop here but didn’t define what SawModel is and didn’t requested to load the model either

You should define the sawmodel (using gethashkey for the prop name if you’re using the prop model/file name) and should also request model to ensure 100% proper functioning

TheIndra · 2019-03-21T15:45:43.336Z

VenomXNL:

and didn’t requested to load the model either

No need to request the model in C# it does it already when you call the function

github.com

citizenfx/fivem/blob/1326de1b2a44de0c2d3197f366713e0856407bef/code/client/clrcore/External/World.cs#L1366-L1371


      
          		public static async Task<Prop> CreateProp(Model model, Vector3 position, bool dynamic, bool placeOnGround)
          		{
          			if (!await model.Request(1000))
          			{
          				return null;
          			}

Also how are you calling the CommandSpawnAsync() function, make sure you are calling it

McFck · 2019-03-21T15:46:15.980Z

I have that defined in code. I took Xander extraction saw for the base.

(const string SawModel = "prop_tool_consaw";)

Its working well. But my command action doesnt work.
Original: [Release] Extraction Saw Script [C#]

VenomXNL · 2019-03-21T15:46:41.482Z

Great THIS i didn’t new about the API haha so will instantly stop doing that myself to haha

SHAME ON ME for not reading up on the basic interfaces

VenomXNL · 2019-03-21T15:55:52.939Z

Due to no response at the moment on:

TheIndra:

Also how are you calling the CommandSpawnAsync() function, make sure you are calling it

What is meant with that is that you would need to call

CommandSpawnAsync()

properly in your (main) code to even register the command “saw” you’ve mentioned

McFck · 2019-03-21T15:58:18.430Z

Oh got it. Yeah Im not calling calling CommandSpawnAsync() anywhere. How to call it?

VenomXNL · 2019-03-21T16:00:06.737Z

Well if you for example “always” want people to be able to use the command and register it just once, you would just register the command by itself without even needing the extra function by just adding this to your main code:

API.RegisterCommand("saw", new Action<int, List<object>, string>(async (src, args, raw) =>
            {

                await RetrieveSaw();
            }), false);

(JUST ONCE and not in a loop )

McFck · 2019-03-21T16:01:58.293Z

So main code would be server.cs ?

VenomXNL · 2019-03-21T16:02:49.789Z

No definitly not, this is a client sided command/snippet (piece of code)

McFck · 2019-03-21T16:07:56.098Z

Register command by itself is just pasting API.RegisterCommand somwhere in client without any function or anything else? Cause right now just parsing the code made loads of errors.

xander1998 · 2019-03-21T16:08:59.325Z

I am so confused on whats going on.

McFck · 2019-03-21T16:10:30.634Z

I am just learning C#. Saw your code like year ago and thought I could try to do something with it.

xander1998 · 2019-03-21T16:11:17.474Z

The client.cs file has a constructor? Right? Why not just define the command in the constructor and use my functions to grab and drop the saw?

VenomXNL · 2019-03-21T16:11:31.227Z

Considering you’re here, i’ll let you take over from here if you don;t mind?

(Since it’s your original script)

VenomXNL · 2019-03-21T16:11:56.860Z

Exactly what i meant But didn’t got right away that he was just starting out haha

xander1998 · 2019-03-21T16:24:37.848Z

Maybe the constructor could look like this

public ExtractionSaw()
{
	EventHandlers.Add("ExtractionSaw:InitializePlayer", new Action<string>(InitializeScript));
	EventHandlers.Add("ExtractionSaw:StartSawSync", new Action<int>(StartSaw));
	EventHandlers.Add("ExtractionSaw:StopSawSync", new Action<int>(StopSaw));
	EventHandlers.Add("ExtractionSaw:RemoteDoorCut", new Action<int, int>(RemoteDoorCut));
	Tick += OnTick;

	API.RegisterCommand("saw", new Action<int, List<object>, string>(async (source, args, raw) => 
	{
		if (CurrentSaw == null)
		{
			await RetrieveSaw();
		}
		else
		{
			StoreSaw();
		}
	}), false)

	// Initialize Client
	TriggerServerEvent("ExtractionSaw:GetInitializedData");
}

McFck · 2019-03-21T16:32:40.086Z

Thanks a lot! Sorry for lots of questions. Its my first year in university just trying to cath up.