GetPlayerRgbColour Native

Ven0m · 2019-09-12T15:52:01.487Z

I’m having some issues with GetPlayerRgbColour native from vrp scoreboard.
Server has OneSync free with 32 slots and scoreboard shows only one colour (dark grey).

This is the playerlist function from Sighmir

Citizen.CreateThread(function()
    listOn = false
    while true do
        Citizen.Wait(0)

        if IsControlPressed(0, 27)--[[ INPUT_PHONE ]] then
            if not listOn then
                local players = ""
                for k, v in pairs(users) do
				  if NetworkIsPlayerActive(GetPlayerFromServerId(v.player)) then
                    r, g, b = GetPlayerRgbColour(GetPlayerFromServerId(v.player))
                    players = players..'<tr style=\"color: rgb(' .. r .. ', ' .. g .. ', ' .. b .. ')\"><td>' .. k .. '</td><td>' .. GetPlayerName(GetPlayerFromServerId(v.player)) .. '</td><td>' .. v.firstname .. " " .. v.name .. '</td><td>' .. (v.job or "") .. '</td></tr>'
				  end
                end
                
                SendNUIMessage({ text = players })

                listOn = true
                while listOn do
                    Citizen.Wait(0)
                    if(IsControlPressed(0, 27) == false) then
                        listOn = false
                        SendNUIMessage({
                            meta = 'close'
                        })
                        break
                    end
                end
            end
        end
    end
end)

So I’ve changed

r, g, b = GetPlayerRgbColour(GetPlayerFromServerId(v.player))

to

r, g, b = GetPlayerRgbColour(v.player)

And this works, every player gets a different colour, but when server reaches id 32 or so, every player after that is dark grey again.

Any fix or workaround for this? I really like the idea of every player having a different colour because they are easier to find on scoreboard.

system · 2019-09-12T15:52:01.651Z

Hello, this is a friendly reminder because this is your first time creating a topic (or it has been a while since your last topic) in this category.

Please note that most of the support is provided by the FiveM community on a voluntary basis. We ask you to be patient; there is no guarantee we have a solution to your problem(s). To avoid unnecessary/duplicate topics, please browse the forums before creating a topic.

To improve your chances of your issue(s) being solved, please provide as much information as possible about the issue(s) you are having. Also —whenever possible— please use the template given to you when creating a topic.

Thanks for keeping these forums tidy!

ChieF-TroN · 2019-09-12T16:23:38.160Z

Chances are it has to do with a 32 player loop being broken when more than that are in the server.

I’d start by looking where its defining users in the

in pairs(users) do

And see how it’s getting the data for users

Ven0m · 2019-09-12T16:28:21.073Z

Thanks for the fast reply, couldn’t find a loop, here is the entire code:

local listOn = false
vRPsb = {}
Tunnel.bindInterface("vrp_scoreboard",vRPsb)
users = {}

function vRPsb.insertUser(user_id,user_source,user_firstname,user_name,user_job)
	users[user_id] = { -- tonumber and tostrings are inlogical in this case
		player = tonumber(user_source), -- but apparently it fixes holes that shouldnt even be on the list in case this was the problem
		firstname = tostring(user_firstname), -- maybe my logic is flawed, but whats the point of converting values to what they are already ?
		name = tostring(user_name), -- this doesn't change anything, but for some, it seems to fix the holes that logically shouldn't even be there
		job = tostring(user_job) -- Better be safe than sorry. Everything should have a logical explanation... maybe not in FiveM. =)
	}
end

function vRPsb.removeUser(user_id)
	users[user_id] = nil
end

function vRPsb.updateUser(user_id,user_job)
	users[user_id].job = user_job
end

Citizen.CreateThread(function()
    listOn = false
    while true do
        Wait(0)

        if IsControlPressed(0, 27)--[[ INPUT_PHONE ]] then
            if not listOn then
                local players = ""
                for k, v in pairs(users) do
				  if NetworkIsPlayerActive(GetPlayerFromServerId(v.player)) then 
                    r, g, b = GetPlayerRgbColour(GetPlayerFromServerId(v.player))
                    players = players..'<tr style=\"color: rgb(' .. r .. ', ' .. g .. ', ' .. b .. ')\"><td>' .. k .. '</td><td>' .. GetPlayerName(GetPlayerFromServerId(v.player)) .. '</td><td>' .. v.firstname .. " " .. v.name .. '</td><td>' .. (v.job or "") .. '</td></tr>'
				  end
                end
                
                SendNUIMessage({ text = players })

                listOn = true
                while listOn do
                    Wait(0)
                    if(IsControlPressed(0, 27) == false) then
                        listOn = false
                        SendNUIMessage({
                            meta = 'close'
                        })
                        break
                    end
                end
            end
        end
    end
end)

and these are the server functions

AddEventHandler("vRP:playerLeave",function(user_id, source) 
	local users = vRP.getUsers({})
	for k,v in pairs(users) do
		SBclient.removeUser(v,{user_id})
	end
end)

AddEventHandler("vRP:playerSpawn", function(user_id, source, first_spawn) 
	local users = vRP.getUsers({})
	for k,v in pairs(users) do
	  vRP.getUserIdentity({k, function(identity)
		SBclient.insertUser(source,{k, v, identity.firstname, identity.name,vRP.getUserGroupByType({k,"job"})})
	  end})
	  vRP.getUserIdentity({user_id, function(identity)
	    SBclient.insertUser(v,{user_id, source, identity.firstname, identity.name,vRP.getUserGroupByType({user_id,"job"})})
	  end})
	end
end)

ChieF-TroN · 2019-09-12T16:32:09.200Z

What is calling the function:

vRPsb.insertUser

I have a feeling that whatever is feeding that data is the issue.

Edit:

Search for the function:

vRP.getUsers

And make sure that gets the correct data.

ChieF-TroN · 2019-09-12T16:39:20.888Z

After further reviewing of the vRP code. This might just be an issue with the framework itself. Because I know that the playerlists get fucked up after some time because vRP isn’t handling the players data properly in the sense it’s not removing old players. Hence why you will see “unknown” as a entry when using the built in playerlists when it is not working correctly.

Ven0m · 2019-09-12T16:43:57.316Z

That might just be it, i found the main getusers functions but still no 32 loop

-- return map of user_id -> player source
function vRP.getUsers()
  local users = {}
  for k,v in pairs(vRP.user_sources) do
    users[k] = v
  end

  return users
end

-- return source or nil
function vRP.getUserSource(user_id)
  return vRP.user_sources[user_id]
end

I guess i’m just gonna have to remove the rgb native function and use one colour for all.
Thanks for your help.

krypton · 2019-09-12T16:45:00.780Z

GTA only has 32 player colors, if you want more different colors you’re going to have to have your own table of colors.

Ven0m · 2019-09-12T16:47:20.685Z

I don’t need more than 32 colors, i just wanted the colour of the disconnected player to be assigned to a new one that connects.

ChieF-TroN · 2019-09-12T16:57:12.783Z

My suggestion then would be to just change how it’s inputting in the color all together.

r = math.random(0,255)
g = math.random(0,255)
b = math.random(0,255)

So that way it just randomizes the color for each user. And is not dependent of the GTA Native at all.

Ven0m · 2019-09-12T17:17:53.748Z

Thank you, i will use this.

system · 2019-10-12T17:28:33.813Z

This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.