ESX.GetPlayers() Server trhead hitch warning

DaviteN · 2021-05-30T18:25:17.860Z

I have 200 people on the server active, and a lot of thread hooks, doing a server-side Profiler, all that generates these thread hooks is this function:

ESX.GetPlayers ()

Is there any other way to do this?

Linden · 2021-06-02T08:11:42.064Z

ESX.GetPlayers() returns a list of player ids that have a character loaded.

Resources that use this function then loop through the IDs and use ESX.GetPlayerFromId(id), then perform a whatever task they want with that without any sort of wait. Sometimes this is an async query - so you send 200 database queries almost all at once, or some events (which are in themselves async).

You can alleviate some of the stress by changing how the xPlayer data is retrieved.

Add the following function to ESX/server/functions.lua

ESX.GetExtendedPlayers = function()
	return ESX.Players
end

Example of a typical xPlayer loop

		local xPlayers = ESX.GetPlayers()
		for _,playerId in ipairs(xPlayers) do
			local xPlayer = ESX.GetPlayerFromId(playerId)

			MySQL.Async.fetchAll('SELECT status FROM users WHERE identifier = @identifier', {
				['@identifier'] = xPlayer.identifier
			}, function(result)
				local data = {}

				if result[1].status then
					data = json.decode(result[1].status)
				end

				xPlayer.set('status', data)
				TriggerClientEvent('esx_status:load', playerId, data)
			end)
		end

Replacement

		local xPlayers = ESX.GetExtendedPlayers()
		for k,v in pairs(xPlayers) do		
			MySQL.Async.fetchAll('SELECT status FROM users WHERE identifier = @identifier', {
				['@identifier'] = v.identifier
			}, function(result)
				local data = {}

				if result[1].status then
					data = json.decode(result[1].status)
				end

				v.set('status', data)
				TriggerClientEvent('esx_status:load', k, data)
			end)
		end

If you are using any resources for blips (for EMS, police, etc) check how they are performing this task as well. By default ambulancejob and policejob send a server event when a cop loads in, which tells all clients to check if they are ems/police and send a server callback.

The callback, which is triggered by (for example) 6 cops then runs 6 async xPlayer loops to get the ids of all active cops and report back to the client.

Lastly, if you are using gcphone then you need to replace the following function

function getSourceFromIdentifier(identifier, cb)
	local xPlayers = ESX.GetPlayers()
	
	for i=1, #xPlayers, 1 do
		local xPlayer = ESX.GetPlayerFromId(xPlayers[i])
		
		if(xPlayer.identifier ~= nil and xPlayer.identifier == identifier) or (xPlayer.identifier == identifier) then
			cb(xPlayer.source)
			return
		end
	end
	cb(nil)
end

Replace with

function getSourceFromIdentifier(identifier, cb)
	local xPlayer = ESX.GetPlayerFromIdentifier(identifier)
	if xPlayer then cb(xPlayer.source) else cb(nil) end
end

DaviteN · 2021-06-02T14:40:51.902Z

You are a genius, now I am not clear in this part how I should replace?

local xAll = ESX.GetExtendedPlayers()
    	for i=1, #xAll, 1 do
      		local xTarget = ESX.GetPlayerFromId(xAll[i])
      		if havePermission(xTarget) then		-- you can exclude some ranks to NOT reciveing reports
        		if xPlayer.source ~= xTarget.source then
		    		TriggerClientEvent('chatMessage', xTarget.source, _U('report', GetPlayerName(xPlayer.source), xPlayer.source, message))
        		end
      		end
		end

or here

local xPlayers = ESX.GetPlayers()

for i=1, #xPlayers, 1 do
		local xPlayer = ESX.GetPlayerFromId(xPlayers[i])
		local status  = xPlayer.get('status')

		whenList = whenList .. string.format('when identifier = \'%s\' then \'%s\' ', xPlayer.identifier, json.encode(status))

		if firstItem == false then
			whereList = whereList .. ', '
		end
		whereList = whereList .. string.format('\'%s\'', xPlayer.identifier)

		firstItem = false
		playerCount = playerCount + 1
	end

Linden · 2021-06-02T20:43:14.118Z

With the table being returned, the key (or index) is equal to the players id (or source), while the value is their xPlayer data.

So k is the same as v.source / v.playerId - up to you how you want to reference it.

You do not need to use ESX.GetPlayerFromId() at all, it is what causes a bulk of the lag (calling functions from other resources has a lot of overhead).


local xPlayers = ESX.GetExtendedPlayers()

for k,v in pairs(xPlayers) do

    if havePermission(v) and xPlayer.source ~= k then

        TriggerClientEvent('chatMessage', k, _U('report', GetPlayerName(xPlayer.source), xPlayer.source, message))

    end

end

In the second example you’re trying to update esx_status, so you can reference my updated version

github.com

thelindat/esx_status/blob/master/server/main.lua

ESX = nil

TriggerEvent('esx:getSharedObject', function(obj) ESX = obj end)

AddEventHandler('onResourceStart', function(resourceName)
	if (GetCurrentResourceName() ~= resourceName) then
	  	return
	end

	local xPlayers
	if ESX.GetExtendedPlayers then	
		xPlayers = ESX.GetExtendedPlayers()		-- Retrieve all xPlayer data directly (ESX Legacy)
	else
		xPlayers = ESX.GetPlayers()				-- Retrieves player ids and gets xPlayer data one-by-one (ESX 1.2 support)
	end
	
	for k,v in pairs(xPlayers) do
		local xPlayer = type(v) ~= 'table' and v or ESX.GetPlayerFromId(k)
		MySQL.Async.fetchAll('SELECT status FROM users WHERE identifier = @identifier', {
			['@identifier'] = xPlayer.identifier

This file has been truncated. show original

I’d appreciate feedback on how all of this performs too, since it’s getting pushed into an update for ESX Legacy.

Edit

Here’s an example of performance when triggering esx_society:getOnlinePlayers with 200 active players.
Keep in mind this is being triggered by a single client - the default blips in esx_policejob trigger the callback for every cop online.

I’ve fixed up esx_society to use the new looping function.

github.com

thelindat/esx_society/blob/master/server/main.lua

ESX = nil
local Jobs = {}
local RegisteredSocieties = {}

TriggerEvent('esx:getSharedObject', function(obj) ESX = obj end)

function GetSociety(name)
	for i=1, #RegisteredSocieties, 1 do
		if RegisteredSocieties[i].name == name then
			return RegisteredSocieties[i]
		end
	end
end

MySQL.ready(function()
	local result = MySQL.Sync.fetchAll('SELECT * FROM jobs', {})

	for i=1, #result, 1 do
		Jobs[result[i].name] = result[i]
		Jobs[result[i].name].grades = {}

This file has been truncated. show original

Edit

Full comparison of performance differences when modifying esx_society.
The top two just swap out the function.
The bottom two modify the callback event to stop it from performing the same task 10 times in quick succession.

DaviteN · 2021-06-03T02:41:49.144Z

Now the only thing that causes me thread snags is the gcphone in this function:

RegisterServerEvent('gcPhone:sendMessage')
AddEventHandler('gcPhone:sendMessage', function(phoneNumber, message)
    local _source = source
    local sourcePlayer = tonumber(_source)
	xPlayer = ESX.GetPlayerFromId(_source)
    identifier = xPlayer.identifier
    addMessage(sourcePlayer, identifier, phoneNumber, message)
end)

Linden · 2021-06-03T03:45:19.133Z

Using the snippet I included in the first reply?

DaviteN · 2021-06-03T06:17:48.861Z

function getSourceFromIdentifier(identifier, cb)
	local xPlayers = ESX.GetExtendedPlayers()
    for k,v in pairs(xPlayers) do
		--if k then cb(k) else cb(nil) end
		if(v.identifier ~= nil and v.identifier == identifier) or (v.identifier == identifier) then
			cb(k)
			return
		end
	end	
end

Linden · 2021-06-03T07:16:37.939Z

function getSourceFromIdentifier(identifier, cb)
	local xPlayer = ESX.GetPlayerFromIdentifier(identifier)
	if xPlayer then cb(xPlayer.source) else cb(nil) end
end

There’s no need to loop through xPlayers to get a source from an identifier.

RealMasBagus · 2021-06-03T11:44:29.358Z

Shouldn’t it be ESX.GetPlayerFromIdentifier(identifier) instead of ESX.GetPlayerFromId(identifier)? since if you are getting xPlayer from Id why do you even need xPlayer xD.

Linden · 2021-06-03T11:45:04.594Z

typo

DaviteN · 2021-06-03T13:17:58.781Z

Linden:

typo

This does not work for me, the SMS do not arrive, I quit the gcphone and everyone arrives, but it is like the SMS are not updated. That’s why I did it as I happened to you.

Linden · 2021-06-03T15:04:23.779Z

The original code I sent had a mistake in it, as RealMasBagus pointed out. I edited the previous messages containing the function.

DaviteN · 2021-06-05T16:20:54.938Z

not found, no refresh de sms

DaviteN · 2021-06-19T06:10:53.401Z

The only way that works for me is the following:

function getSourceFromIdentifier(identifier, cb)
	local xPlayers = ESX.GetExtendedPlayers()
    for k,v in pairs(xPlayers) do
		--if k then cb(k) else cb(nil) end
		if(v.identifier ~= nil and v.identifier == identifier) or (v.identifier == identifier) then
			cb(k)
			return
		end
	end	
end

But all the high thread hooks are given to me by the gcphone, when they send sms.

11381×273 18.8 KB

It is the following line:

RegisterServerEvent('gcPhone:sendMessage')
AddEventHandler('gcPhone:sendMessage', function(phoneNumber, message, gpsData)
    local _source = source
    local sourcePlayer = tonumber(_source)
	xPlayer = ESX.GetPlayerFromId(_source)
    identifier = xPlayer.identifier
    addMessage(sourcePlayer, identifier, phoneNumber, message, gpsData)
end)

system · 2021-07-19T06:11:49.203Z

This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.