Best Practices Question (Game VS API VS Function.Call) (C#)

AnExiledGod · 2019-06-22T08:57:04.944Z

Been diving into C# modding pretty extensively and it’s a little overwhelming, especially since there’s many more LUA mods than C# mods.

I’m trying to determine some best practices before I get too far into my project.
With the below 3 functions which would be the best choice from a performance perspective, I’ve read Function.Call is the least performant, but why? Are there any real differences between them?

Game.PlayerPed.IsVisible = false;
API.SetEntityVisible(PlayerPedId(), false, false);
Function.Call(Hash.SET_ENTITY_VISIBLE, PlayerPedId(), false, false);

I’ve been using the below reference documents while developing, do you know of any others that would be helpful to me?

https://runtime.fivem.net/doc/natives
http://www.dev-c.com/nativedb/

GitHub

CitizenFX Collective

The CitizenFX Collective is the group delivering powerful products such as FiveM. - CitizenFX Collective

Any help is greatly appreciated!

d0p3t · 2019-06-22T09:08:38.461Z

Don’t ever use Function.Call if there’s a native function already
The CitizenFX.Core methods/classes are just helper methods/classes around the existing API. See https://github.com/citizenfx/fivem/tree/master/code/client/clrcore/External for a full list.

As you can see, these classes just wrap around natives, so it’s up to you what you want to use. Personally I prefer using the CitizenFX.Core helper classes as much as possible unless I require some custom logic.

Examples:

API.PlayerPedId() == Game.PlayerPed.Handle
API.SetEntityCoords(myPed, x, y, z, etc...) == Game.PlayerPed.Position = new Vector3(x,y,z)

AnExiledGod · 2019-06-22T20:01:32.607Z

Awesome! Thanks for the help, even answered a few questions I didn’t have yet.